ION SDK #307

decentralgabe · 2023-03-17T23:14:38Z

Add feature parity to the following repos:

https://github.com/decentralized-identity/ion-sdk

codecov-commenter · 2023-03-17T23:21:51Z

Codecov Report

Merging #307 (2477b7d) into main (a243dcc) will increase coverage by 0.23%.
The diff coverage is 61.52%.

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   58.68%   58.91%   +0.23%     
==========================================
  Files          42       45       +3     
  Lines        4717     5125     +408     
==========================================
+ Hits         2768     3019     +251     
- Misses       1462     1568     +106     
- Partials      487      538      +51

Impacted Files	Coverage Δ
credential/status/statuslist2021.go	`64.65% <ø> (ø)`
did/did.go	`100.00% <ø> (ø)`
did/peer.go	`65.58% <ø> (ø)`
did/web.go	`67.80% <ø> (ø)`
did/ion/did.go	`46.00% <46.00%> (ø)`
did/ion/crypto.go	`62.88% <62.88%> (ø)`
did/ion/request.go	`64.16% <64.16%> (ø)`

decentralgabe · 2023-03-19T06:42:39Z

depends on #308

* main: Bump github.com/goccy/go-json from 0.10.0 to 0.10.2 (#310) Bump golang.org/x/term from 0.5.0 to 0.6.0 (#299) Update JWX lib to use v2 (#308) # Conflicts: # credential/signing/jws.go # credential/signing/jwt.go # crypto/jwk_test.go # crypto/jwt.go # go.mod # go.sum # wasm/static/main.wasm

andresuribe87 · 2023-03-20T20:43:16Z

did/ion/crypto.go

+	privateKey *btcec.PrivateKey
+}
+
+// NewBTCSignerVerifier creates a new signer/verifier for signatures suited for the BTC blockchain


Is a signer/verifier meant to implement a specific interface? There exists cryptosuite.Signer, but it's unclear to me what they should represent.

not a specific interface, just a utility to wrap the key

did/ion/crypto_test.go

andresuribe87 · 2023-03-20T21:35:21Z

did/ion/crypto_test.go

There are a lot of methods above that aren't tested. What's the rationale for not doing so?

they are all tested through the test vectors, though not directly

did/ion/did.go

did/ion/request.go

andresuribe87 · 2023-03-20T21:53:33Z

did/ion/request.go

+	publicKeys := make(map[string]PublicKey)
+	for _, publicKey := range s.PublicKeysToAdd {
+		if _, ok := publicKeys[publicKey.ID]; ok {
+			return fmt.Errorf("public key<%s> is duplicated", publicKey.ID)


Here and elsewhere. If you want stack traces, use errors.Errorf. See https://stackoverflow.com/questions/61933650/whats-the-difference-between-errors-wrapf-errors-errorf-and-fmt-errorf for more details. (make sure it's not the native "errors" library).

good to know this, will update

did/ion/request.go

andresuribe87 · 2023-03-20T21:55:15Z

did/ion/request.go

+	toBeSigned := struct {
+		UpdateKey crypto.PublicKeyJWK `json:"updateKey"`
+		DeltaHash string              `json:"deltaHash"`
+	}{


Curious why an anonymous struct here vs defining it in model.go ?

ah was all anonymous first, forgot to update this

andresuribe87 · 2023-03-20T21:56:28Z

did/ion/request.go

+// NewUpdateRequest creates a new update request https://identity.foundation/sidetree/spec/#update
+func NewUpdateRequest(didSuffix string, updateKey, nextUpdateKey crypto.PublicKeyJWK, signer BTCSignerVerifier, stateChange StateChange) (*UpdateRequest, error) {
+	if err := stateChange.IsValid(); err != nil {
+		return nil, err


Here and elsewhere in this func. I recommend chaining errors with either Wrap or using : and Errorf. See https://github.com/uber-go/guide/blob/master/style.md#error-wrapping for more details.

Co-authored-by: Andres Uribe <auribe@tbd.email>

* origin/main: Bump github.com/multiformats/go-multibase from 0.1.1 to 0.2.0 (#313) Bump github.com/go-playground/validator/v10 from 10.11.2 to 10.12.0 (#311) # Conflicts: # go.mod # go.sum

andresuribe87

Not blocking, but part of an important convo.

andresuribe87 · 2023-03-21T17:57:25Z

did/ion/model.go

+}
+
+type Delta struct {
+	Patches          []any  `json:"patches,omitempty"`


It's the classic oneof problem with golang, which has no great support :(

We could use the protobuf approach. It's a bit of additional work, but I think it's worth it. What are your thoughts?

decentralgabe · 2023-03-21T19:30:49Z

@andresuribe87 I agree protobufs would work. I think JSON schemas would be a simpler solution.

since the source of truth is going to be an ion node (which will reject an invalid request) I think we are OK for now, but should think about it as an improvement

* origin/main: ION SDK (#307) # Conflicts: # wasm/static/main.wasm

* origin/main: make target optional (#316) ION SDK (#307) # Conflicts: # go.mod # go.sum # wasm/static/main.wasm

gabe and others added 3 commits March 16, 2023 18:16

ion models

177bffb

long form did and initial request

10dd502

Merge branch 'main' into ion-sdk-tools

7c9727a

decentralgabe changed the title ~~Ion sdk tools~~ ION SDK & Tools Mar 17, 2023

decentralgabe changed the title ~~ION SDK & Tools~~ ION SDK Mar 17, 2023

gabe added 8 commits March 17, 2023 17:36

deactivate request

58ab972

update request

d440ab2

recover

caf7df0

lint

1d4a36a

test not passing

578659e

fix test

89b26f1

fix reveal value; update test

fad5e40

temp

e0ee678

decentralgabe force-pushed the ion-sdk-tools branch from 57bd763 to 7a3de7d Compare March 19, 2023 06:46

up to date

6daff52

decentralgabe force-pushed the ion-sdk-tools branch from 7a3de7d to 6daff52 Compare March 19, 2023 06:49

gabe added 12 commits March 18, 2023 23:50

update signature has different value even though content is the same

6ca2fe1

update tests work

1f398dd

using btc signer

e4e2cf3

deterministic signatures but not matching yet?

72c3679

compact hex but not working

c1b45b9

need fixed length strings

5f413ac

thanks chad

b7094ca

less janky

37bc2c5

no dice

4e29d6b

tmp

428fa7c

temp

b000982

it should work but it don't

d1a10b6

gabe added 8 commits March 20, 2023 12:07

almost

e99d598

remove unnecessary

b9b4065

merge

6eb59be

it works

f1de4be

result test vectors passing

c7c66ef

more test vectors

0600982

comments

c20d39c

decentralgabe marked this pull request as ready for review March 20, 2023 20:13

decentralgabe requested review from nitro-neal and andresuribe87 as code owners March 20, 2023 20:13

andresuribe87 reviewed Mar 20, 2023

View reviewed changes

gabe and others added 9 commits March 20, 2023 15:32

remove unnecessary test and godoc

4a5a86d

Update did/ion/request.go

594c80a

Co-authored-by: Andres Uribe <auribe@tbd.email>

Update did/ion/request.go

b7f8193

Co-authored-by: Andres Uribe <auribe@tbd.email>

Apply suggestions from code review

f68ecdf

Co-authored-by: Andres Uribe <auribe@tbd.email>

pr comments

eaeeaaf

update errs

2477b7d

all pr comments

a458649

Merge remote-tracking branch 'origin/main' into ion-sdk-tools

6a0d440

* origin/main: Bump github.com/multiformats/go-multibase from 0.1.1 to 0.2.0 (#313) Bump github.com/go-playground/validator/v10 from 10.11.2 to 10.12.0 (#311) # Conflicts: # go.mod # go.sum

merge

ccf95f8

andresuribe87 approved these changes Mar 21, 2023

View reviewed changes

decentralgabe merged commit 9ef2f8d into main Mar 21, 2023

decentralgabe deleted the ion-sdk-tools branch March 21, 2023 19:30

decentralgabe pushed a commit that referenced this pull request Mar 22, 2023

Merge remote-tracking branch 'origin/main' into remove-optional-target

eaab940

* origin/main: ION SDK (#307) # Conflicts: # wasm/static/main.wasm

decentralgabe pushed a commit that referenced this pull request Mar 22, 2023

Merge remote-tracking branch 'origin/main' into bbs-plus

f1fee95

* origin/main: make target optional (#316) ION SDK (#307) # Conflicts: # go.mod # go.sum # wasm/static/main.wasm

This was referenced Mar 24, 2023

ION Reads & Writes TBD54566975/ssi-service#340

Closed

did:ion support #30

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ION SDK #307

ION SDK #307

decentralgabe commented Mar 17, 2023 •

edited

Loading

codecov-commenter commented Mar 17, 2023 •

edited

Loading

decentralgabe commented Mar 19, 2023

andresuribe87 Mar 20, 2023

decentralgabe Mar 20, 2023

andresuribe87 Mar 20, 2023

decentralgabe Mar 20, 2023

andresuribe87 Mar 20, 2023

decentralgabe Mar 20, 2023

andresuribe87 Mar 20, 2023

decentralgabe Mar 20, 2023

andresuribe87 Mar 20, 2023

decentralgabe Mar 20, 2023

andresuribe87 left a comment

andresuribe87 Mar 21, 2023

decentralgabe commented Mar 21, 2023

ION SDK #307

ION SDK #307

Conversation

decentralgabe commented Mar 17, 2023 • edited Loading

codecov-commenter commented Mar 17, 2023 • edited Loading

Codecov Report

decentralgabe commented Mar 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andresuribe87 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

decentralgabe commented Mar 21, 2023

decentralgabe commented Mar 17, 2023 •

edited

Loading

codecov-commenter commented Mar 17, 2023 •

edited

Loading