Fix readme, fix publish issue #152
Conversation
| @@ -151,7 +151,7 @@ tasks.dokkaHtmlMultiModule { | |||
|
|
|||
| publishing { | |||
| publications { | |||
| create<MavenPublication>("tbdex") { | |||
| create<MavenPublication>(rootProject.name) { | |||
| groupId = project.group.toString() | |||
| artifactId = name | |||
| description = "Kotlin SDK for tbdex functionality" | |||
There was a problem hiding this comment.
thinking i should somehow enable us to package all 3 projects exported under 1 name - tbdex. looking into shadow jars
There was a problem hiding this comment.
nvm found how to do it here
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 76.94% 77.34% +0.40%
==========================================
Files 33 33
Lines 785 799 +14
Branches 80 80
==========================================
+ Hits 604 618 +14
Misses 134 134
Partials 47 47
|
…adle.kts to include dependencies so we can publish rollup
| @@ -20,6 +21,9 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api(project(":protocol")) | |||
There was a problem hiding this comment.
we needed these to actually get all 3 subprojects when we pull in tbdex as a dependency
| val signingPassword: String? by project | ||
| useInMemoryPgpKeys(signingKey, signingPassword) | ||
| sign(publishing.publications[publicationName]) | ||
| if (!project.hasProperty("skipSigning") || project.property("skipSigning") != "true") { |
There was a problem hiding this comment.
adding this allows you to build artifacts locally even without a signing key and password like this
./gradlew publishToMavenLocal -PskipSigning=true -Pversion={your-local-version-name}
jiyoontbd
requested review from
mistermoe,
phoebe-lew,
michaelneale,
KendallWeihe,
ethan-tbd,
tomdaffurn,
diehuxx and
kirahsapong
as code owners
README.md
Outdated
| maven("https://jitpack.io") | ||
| maven("https://repo.danubetech.com/repository/maven-public/") | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation("com.github.TBD54566975:tbdex:0.4.0-beta") |
There was a problem hiding this comment.
Do we need to update this to reflect the new group id and version?
There was a problem hiding this comment.
oh yea. i missed this in merge conflict fix. ty!
closes #153
also bumping all instances of jackson dependencies to be the same
2.14.2