Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove queryParams from ListExchanges #312

Closed
kirahsapong opened this issue Apr 9, 2024 · 1 comment
Closed

Remove queryParams from ListExchanges #312

kirahsapong opened this issue Apr 9, 2024 · 1 comment

Comments

@kirahsapong
Copy link
Contributor

With the spec returning { data: [id, id, id] } from any GET /exchanges call, it becomes redundant to pass queryParams of exchangeIds. Should remove
This was referenced Apr 9, 2024
Open
Open
Open
thehenrytsai added a commit that referenced this issue Apr 18, 2024
@thehenrytsai
#312 - Removed query params for listing exchanges
4dd6087
@thehenrytsai thehenrytsai mentioned this issue Apr 18, 2024
Merged
thehenrytsai added a commit that referenced this issue Apr 19, 2024
@thehenrytsai
#312 - Removed query params for listing exchanges (#315)
a33d90d
@thehenrytsai
Copy link
Member

This is now done.

@thehenrytsai thehenrytsai mentioned this issue Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SDK Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thehenrytsai @kirahsapong