Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CLI DID creation arg structure #84

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Change CLI DID creation arg structure #84

merged 6 commits into from
Mar 5, 2024

Conversation

KendallWeihe
Copy link
Contributor

Originally thought of here #77

This way we're consistent with the web5 did resolve

Previously

$> web5 did:jwk create

$> web5 did:web create <domain>

Now

$> web5 did create jwk

$> web5 did create web <domain>

KendallWeihe and others added 5 commits February 27, 2024 11:27
@KendallWeihe
Update README
2450b38
@mistermoe
Merge branch 'main' into kendallw/reorder-did-create-args
4d8ad1a
@mistermoe @KendallWeihe
resolve merge conflict and capitalize ABBRV
d28a1d7 
Co-Authored-By: Kendall Weihe <kendallweihe@gmail.com>
@mistermoe @KendallWeihe
fix ABBRV casing
52eeb41 
Co-Authored-By: Kendall Weihe <kendallweihe@gmail.com>
@mistermoe @KendallWeihe
make linter happy
c6d210d 
Co-Authored-By: Kendall Weihe <kendallweihe@gmail.com>
@mistermoe mistermoe merged commit c05e1fc into main Mar 5, 2024
3 checks passed
@mistermoe mistermoe deleted the kendallw/reorder-did-create-args branch March 5, 2024 15:10
@KendallWeihe KendallWeihe mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe mistermoe approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@mihai-chiorean mihai-chiorean Awaiting requested review from mihai-chiorean mihai-chiorean is a code owner

@tomdaffurn tomdaffurn Awaiting requested review from tomdaffurn tomdaffurn is a code owner

@wesbillman wesbillman Awaiting requested review from wesbillman wesbillman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KendallWeihe @mistermoe