-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wallet connect options for Web5.connect() #694
Conversation
🦋 Changeset detectedLatest commit: 27c66a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-06-25T17:23:11Z |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 90.90% 90.92% +0.01%
==========================================
Files 119 119
Lines 30106 30167 +61
Branches 2249 2250 +1
==========================================
+ Hits 27369 27429 +60
- Misses 2702 2703 +1
Partials 35 35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but should we include changesets
with this PR?
Also remember to create a separate one for api
vs the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving but the workspace:* stuff probably needs to get overwritten by the next release run
27c66a5
dwn-sdk-js
(v0.3.10)workspace:*
syntax to always keep "agent" dependency in sync to avoid manual updates/mistakes.