Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wallet connect options for Web5.connect() #694

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

thehenrytsai
Copy link
Member

@thehenrytsai thehenrytsai commented Jun 21, 2024

  1. Added WalletConnectOptions for the connect flow.
  2. Updated to latest dwn-sdk-js (v0.3.10)
  3. Fixed npm audit vulnerability GHSA-3h5v-q93c-6h6q
  4. Updated "agent" dependencies using workspace:* syntax to always keep "agent" dependency in sync to avoid manual updates/mistakes.

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 27c66a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@web5/crypto-aws-kms Patch
@web5/identity-agent Patch
@web5/credentials Patch
@web5/proxy-agent Patch
@web5/user-agent Patch
@web5/common Patch
@web5/crypto Patch
@web5/agent Patch
@web5/dids Patch
@web5/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thehenrytsai thehenrytsai marked this pull request as draft June 21, 2024 23:40
Copy link
Contributor

github-actions bot commented Jun 24, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-06-25T17:23:11Z 27c66a5

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 98.79518% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.92%. Comparing base (617e9a9) to head (27c66a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
+ Coverage   90.90%   90.92%   +0.01%     
==========================================
  Files         119      119              
  Lines       30106    30167      +61     
  Branches     2249     2250       +1     
==========================================
+ Hits        27369    27429      +60     
- Misses       2702     2703       +1     
  Partials       35       35              
Components Coverage Δ
agent 80.86% <96.42%> (+<0.01%) ⬆️
api 94.15% <100.00%> (+0.14%) ⬆️
common 98.68% <ø> (ø)
credentials 94.88% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@thehenrytsai thehenrytsai marked this pull request as ready for review June 24, 2024 20:03
@thehenrytsai thehenrytsai changed the title [WIP] Added wallet connect options for Web5.connect() Added wallet connect options for Web5.connect() Jun 24, 2024
Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few changes needed

packages/api/src/web5.ts Show resolved Hide resolved
packages/api/src/web5.ts Outdated Show resolved Hide resolved
packages/api/package.json Show resolved Hide resolved
LiranCohen
LiranCohen previously approved these changes Jun 24, 2024
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should we include changesets with this PR?

Also remember to create a separate one for api vs the others.

LiranCohen
LiranCohen previously approved these changes Jun 24, 2024
shamilovtim
shamilovtim previously approved these changes Jun 25, 2024
Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but the workspace:* stuff probably needs to get overwritten by the next release run

@thehenrytsai thehenrytsai dismissed stale reviews from shamilovtim and LiranCohen via 27c66a5 June 25, 2024 17:20
@thehenrytsai thehenrytsai merged commit cc3aa58 into main Jun 25, 2024
35 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/web5-wallet-connect-options branch June 25, 2024 18:24
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants