Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rawMessage public on the Record class #745

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

LiranCohen
Copy link
Member

  • rawMessage property on the Record class is not private
  • skip did:ion test in the credentials package

Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 90e65bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 12, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-07-12T17:50:12Z 90e65bb

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (5b0c61a) to head (90e65bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   91.36%   91.35%   -0.01%     
==========================================
  Files         119      119              
  Lines       30194    30194              
  Branches     2293     2293              
==========================================
- Hits        27587    27584       -3     
- Misses       2573     2576       +3     
  Partials       34       34              
Components Coverage Δ
agent 81.74% <ø> (ø)
api 95.39% <100.00%> (ø)
common 98.68% <ø> (ø)
credentials 94.68% <ø> (-0.21%) ⬇️
crypto 93.81% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

Copy link
Member

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@LiranCohen LiranCohen merged commit a956f72 into main Jul 12, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/rawMessage-public branch July 12, 2024 18:32
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants