generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VC Verify more robust #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
mistermoe,
tomdaffurn,
phoebe-lew,
diehuxx,
kirahsapong,
jiyoonie9 and
frankhinek
as code owners
April 1, 2024 20:49
@nitro-neal can you link the spec text where we talk about the date fields like exp iat nbf being numeric values? @kirahsapong and i were wondering about whether it should be a date or a long field while working in web5-swift. |
jiyoonie9
reviewed
Apr 1, 2024
credentials/src/test/kotlin/web5/sdk/credentials/VerifiableCredentialTest.kt
Outdated
Show resolved
Hide resolved
here is vcdata model - https://www.w3.org/TR/vc-data-model/#jwt-encoding |
nitro-neal
commented
Apr 1, 2024
credentials/src/test/kotlin/web5/sdk/credentials/PresentationExchangeTest.kt
Show resolved
Hide resolved
jiyoonie9
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added vcJwt checks to verify
Description
How Has This Been Tested?
Added new vector - TBD54566975/web5-spec#146