Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #323: Enforce jackson-dataformat-cbor to aligned version #326

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ALRubinger
Copy link
Contributor

Addresses #323

@ALRubinger
Copy link
Contributor Author

Needed to add dependencyManagement for both jackson-dataformat-cbor and jackson-dataformat-yaml.

Proof all are aligned in com.fasterxml.jackson.databind:

$> mvn dependency:tree -Dincludes=com.fasterxml.jackson.dataformat
...
[INFO] xyz.block:web5-credentials:jar:0.0.0-main-SNAPSHOT
[INFO] +- xyz.block:web5-crypto:jar:0.0.0-main-SNAPSHOT:compile
[INFO] |  \- com.amazonaws:aws-java-sdk-kms:jar:1.12.668:compile
[INFO] |     \- com.amazonaws:aws-java-sdk-core:jar:1.12.668:compile
[INFO] |        \- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.17.0:compile
[INFO] \- com.networknt:json-schema-validator:jar:1.0.87:compile
[INFO]    \- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.17.0:compile

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (489ca78) to head (9ac4210).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   73.60%   73.60%           
=======================================
  Files          45       45           
  Lines        2163     2163           
  Branches      402      402           
=======================================
  Hits         1592     1592           
  Misses        376      376           
  Partials      195      195           
Components Coverage Δ
credentials 81.31% <ø> (ø)
crypto 49.16% <ø> (ø)
dids 80.50% <ø> (ø)
common 65.21% <ø> (ø)

Copy link
Member

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mistermoe mistermoe merged commit d9a3c15 into main Jun 27, 2024
10 checks passed
@mistermoe mistermoe deleted the issue-323/enforce-jackson-dataformat-cbor branch June 27, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants