Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the IP on publishing PreLoginEvent. (Bug Fix) #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the IP on publishing PreLoginEvent. (Bug Fix) #72

wants to merge 1 commit into from

Conversation

Rollczi
Copy link

@Rollczi Rollczi commented Oct 29, 2021

@Rollczi Rollczi mentioned this pull request Oct 29, 2021
Closed
@DylanKeir
Copy link
Member

Apologies, what's the purpose of this? You seem to have re-introduced an event which was previously causing issues due to not having the correct hostname data. I understand your approach might've been to have player#setIP called for the player to have the correct IP but AFAIK that's already handled on handshake and the handleHandshake is returned anyway if true is passed and the event spits out the erroneous data, which doesn't seem like an absolute fix for this. I need to do some debugging on my end with Velocity to figure out why sometimes the hostname passed is incorrect only for PreLoginEvent - I'll get back to you on this.

@Rollczi
Copy link
Author

Rollczi commented Oct 29, 2021

okey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rollczi @DylanKeir