Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeedbackSession: After publishing, edit page shows 1970 as published time #1095

Closed
damithc opened this issue May 2, 2014 · 10 comments
Closed
Labels
c.Bug Bug/defect report
Milestone

Comments

@damithc
Copy link
Contributor

damithc commented May 2, 2014

From dam...@gmail.com on August 03, 2013 20:23:37

This may be confusing to the user. May be set the response published time to current time (user time zone) when the user publish it manually?

Should we rename the option to 'publish manually later' to indicate that it is not published yet.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1096

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on August 03, 2013 05:33:06

Renaming is not necessary.
If I remember correctly, we decided to keep the 'publish manually' option selected even after the user published it manually. The bug here is not translating the 1970 date back to the correct option.

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From ravenxce on August 03, 2013 05:52:13

Status: Started
Owner: ravenxce

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From ravenxce on August 03, 2013 06:32:25

https://codereview.appspot.com/12411043/

Status: ReadyForReview

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on August 03, 2013 07:40:45

Need test coverage.

Status: ChangesRequested

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From ravenxce on August 04, 2013 04:04:56

Test added: https://codereview.appspot.com/12411043/

Status: ReadyForReview

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on August 04, 2013 06:52:52

Status: ReadyToMerge

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From ravenxce on August 04, 2013 08:19:22

This issue was updated by revision 48492a239db0 .

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From ravenxce on August 05, 2013 00:01:08

Status: Delivered

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on August 10, 2013 19:36:48

Status: Deployed
Labels: Milestone-V4.59

@damithc damithc closed this as completed May 2, 2014
@damithc
Copy link
Contributor Author

damithc commented Jul 24, 2014

[Change Log]
status: null ~> status.closed

@thyageshm thyageshm modified the milestone: V4.59 Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report
Projects
None yet
Development

No branches or pull requests

2 participants