Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify masquerade mode in docs #12466

Closed
NicolasCwy opened this issue Jun 5, 2023 · 10 comments · Fixed by #12595
Closed

Clarify masquerade mode in docs #12466

NicolasCwy opened this issue Jun 5, 2023 · 10 comments · Fixed by #12595
Labels
a-Docs User or developer docs good first issue Easy; restricted for first-time contributors

Comments

@NicolasCwy
Copy link
Contributor

NicolasCwy commented Jun 5, 2023

The docs on masquerade mode is unclear on what username is on the development server

When logged in as administrator, masquerade mode can also be used to impersonate instructors and students by adding user=username to the URL e.g http://localhost:8080/web/student/home?user=johnKent.

Developers who want to use masquerade mode have to ensure that theusername is the email address used to verify the user e.g (person@x.com) when signing up mock instructors. Username such as jack (for google id jack@example.com) would not work as the username.

image
Signed up jack@example.com as instructor, which is also used as google id

image
Incorrect username used (jack)

image
Correct username used (jack@example.com)

@NicolasCwy NicolasCwy added good first issue Easy; restricted for first-time contributors a-Docs User or developer docs labels Jun 5, 2023
@wkurniawan07
Copy link
Member

Remnant of #11586.

Now that I see this page again, we might need to reword "Google ID" in places where they are used, because once Firebase is integrated (it already is, but not actually used yet) that term will stop making sense.

But don't let that be a distraction; this issue simply calls for documentation update.

@VishnuRameshbabu
Copy link

Hello there,

I have suggestion regarding this. Maybe we can rename the term 'Google ID' to 'Gmail ID' wherever applicable so people can refer it as their gmail address and not the other way?

@zhaojj2209
Copy link
Contributor

Maybe we can rename the term 'Google ID' to 'Gmail ID' wherever applicable so people can refer it as their gmail address and not the other way?

Thanks for the effort, but that's not what we meant by rewording "Google ID". As mentioned above, we have recently integrated Firebase for authentication, so emails used for accounts are no longer limited to Google emails. We should avoid using the terms "Google"/"Gmail" altogether when referring to user account emails.

@domlimm
Copy link
Contributor

domlimm commented Jun 8, 2023

Should we also add steps to how one can use the masquerade feature? There was a recent discussion here.

@NicolasCwy
Copy link
Contributor Author

Should we also add steps to how one can use the masquerade feature? There was a recent discussion here.

Yup this sounds like a good idea, it has always been a point of confusion for me. Perhaps we can add the instructions in a new section and link the existing reference in this post to it

@domlimm
Copy link
Contributor

domlimm commented Jun 11, 2023

@NicolasCwy alright! Should we do it in the same PR that solves this current issue?

@NicolasCwy
Copy link
Contributor Author

@domlimm Yup if possible, it would be good

@domlimm
Copy link
Contributor

domlimm commented Jun 13, 2023

Apologies for spamming up this issue.

@NicolasCwy On second thought, let's open up another issue as a good first one. It might be rather complex for the current author of the PR to try it out and add the docs. If you're good with this, I can make the issue.

Do you reckon we should add a new sub-section between Logging in to a TEAMMATES instance and Logging in without UI?

image

@NicolasCwy
Copy link
Contributor Author

NicolasCwy commented Jun 13, 2023

@domlimm Ok sounds good to me. I think we can put it after the login without UI, so we can group the login docs together. Then we can link the current snippet on masquerade to the new section which elaborates on how to use masquerade

Made an issue #12473

@jasonqiu212
Copy link
Contributor

jasonqiu212 commented Sep 26, 2023

Hi @vimalJD, Yes this issue is still open! Feel free to submit a PR for it :)

Just to reiterate the main problem in this issue:

When logged in as administrator, masquerade mode can also be used to impersonate instructors and students by adding user=username to the URL e.g http://localhost:8080/web/student/home?user=johnKent.

The above line in the docs (Under the "As administrator" dropdown panel) is unclear on what username is.

Since we now have a section dedicated to explaining how to use masquerade mode in detail (#12506), a simple solution to this issue is:

  • Replace the problematic line above with a link to the new section:
    • When logged in as administrator, masquerade mode can be used to impersonate instructors and students. For more information, refer to Masquerading as another user.

weiquu pushed a commit that referenced this issue Oct 2, 2023
* Add link to masquerade docs

* Change link format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Docs User or developer docs good first issue Easy; restricted for first-time contributors
Projects
None yet
6 participants