[#10874] Finalize Migration to Github Actions #10905

rrtheonlyone · 2021-01-01T16:45:01Z

Part of #10874

Updated build.gradle:
- remove temporary file directory change in CI for jvm (not sure why this was done earlier)
- file deletion was not done earlier in CI environment - I left it as is
Updated documentation to mention Github Actions and added status badge to README
Removed Travis related files
Split to 2 workflow files for component and E2E tests

teammates-bot · 2021-01-01T16:45:12Z

Hi @rrtheonlyone, these parts of your pull request do not appear to follow our contributing guidelines:

PR Title
- Issue Reference (#<issue-number>) missing.

wkurniawan07 · 2021-01-01T17:18:57Z

Remove Appveyor as well?

wkurniawan07 · 2021-01-02T15:00:02Z

We should separate main workflow into E2E and component tests

It actually makes more sense to separate into back-end, front-end, and E2E. It fits our paradigm of separation between back-end and front-end better.

Add: although, it might not work for Codecov. If it really doesn't perhaps we should keep the status quo or use multiple code coverage services.

madanalogy · 2021-01-03T06:53:57Z

I know coveralls supports merging different code coverage reports (used it recently for a project) but not sure about codecov. Maybe take a look at https://docs.codecov.io/docs/merging-reports

wkurniawan07 · 2021-01-03T07:02:44Z

Now that I think about it again, if we do go down the separate back end and front end workflow, then the coverage report needs to be separate as well otherwise it defeats the purpose. Of course, that's an if.

rrtheonlyone · 2021-01-03T08:45:05Z

So just to double check, our current options are:

Keep it as is so we have one coverage report and one build status (build status is tagged to workflow) to show in README. However, we lose the ability to restart specific tests like E2E tests. We have to restart the entire workflow.
Split into backend/frontend/E2E workflos and have multiple status badges. Also find some way to handle codecov for the separate runs (either through https://docs.codecov.io/docs/flags or https://docs.codecov.io/docs/merging-reports). This will however, allow us to rerun groups of tests without running everything again.

wkurniawan07 · 2021-01-04T01:26:00Z

Keep it as is so we have one coverage report and one build status (build status is tagged to workflow) to show in README.

Not really, keeping to status quo is never a considered option. It's either split to E2E + everything else (one coverage report, up to two build statuses) or split to BE/FE/E2E (two coverage reports, up to three build statuses). And as I mentioned before, if we do split BE/FE, it's more logical to also split the coverage reports.

rrtheonlyone · 2021-01-09T16:49:28Z

Okay for now went with option (1) above. One coverage report + 2 build status:

@damithc do we want to set it up such that on any change made to release branch, we run the E2E tests on multiple browsers and os? It is a simple change to do as well.

damithc · 2021-01-09T17:24:40Z

@damithc do we want to set it up such that on any change made to release branch, we run the E2E tests on multiple browsers and os? It is a simple change to do as well.

We know production servers are Unix, so perhaps no need to run on other OS? Testing on multiple browsers might be nice to have. We can try it for a while to see how it goes, if you don't see any downsides. Are the tests equally stable on different browsers?

wkurniawan07 · 2021-01-10T03:03:07Z

We know production servers are Unix, so perhaps no need to run on other OS?

This reasoning is not accurate. E2E goes beyond just testing back-end; the front-end should be tested and is very much dependent on user (which means it is virtually limitless).

In fact, if we follow that line of reasoning, it is the back-end test that needs not be done on non-Unix. We still do it anyway because the cost is very low (and also to cater to Windows-based devs). But probably we should do it only on pushes to master and release to save some time/resources.

Speaking of cross-browser and cross-OS test, this is where services like Saucelabs will be useful for us. Probably it's about time to finish up #9597 for good.

damithc · 2021-01-10T03:06:34Z

This reasoning is not accurate. E2E goes beyond just testing back-end; the front-end should be tested and is very much dependent on user (which means it is virtually limitless).

Oh right, I forgot that part.

rrtheonlyone · 2021-01-10T11:38:46Z

Okay guess we retain this for now.

We run component tests + linting on windows/ubuntu and only run E2E on firefox/ubuntu at the moment. We can play around with more options in future.

I can create a separate PR to add in multiple browsers + OS when we push to release branch. Last time when I checked chrome browser tests did fail more often.

Ready for review

wkurniawan07

Also, do one last round of check that there is no more mention of "Travis" or "Appveyor" in the repo.

README.md

docs/development.md

.github/workflows/component.yml

wkurniawan07 · 2021-01-10T14:51:57Z

docs/process.md

@@ -173,12 +173,12 @@ Their full descriptions can be viewed under the [labels page](https://github.com
 #### Code review

 Your code will be reviewed, in this sequence, by:
-* Travis CI: by running static analysis.<br>
+* Github Actions: by running static analysis.<br>
  If there are problems found, the build will terminate without proceeding to testing.<br>


I don't think this line is accurate anymore; it was in V6

yup removed

docs/process.md

wkurniawan07

Minor comments added. Almost there.

wkurniawan07 · 2021-02-07T15:10:27Z

docs/development.md

@@ -223,8 +223,10 @@ There are several files used to configure various aspects of the system.
 * `gradle.properties`, `gradle-wrapper.properties`: Contains the Gradle and Gradle wrapper configuration.
 * `package.json`: Contains the front-end third-party dependencies specification, as well as configurations for automated tasks/routines to be run via NPM.
 * `angular.json`: Contains the Angular application configuration.
-* `.travis.yml`: Contains the Travis CI job configuration.
-* `appveyor.yml`: Contains the AppVeyor CI job configuration.
+* `component.yml`: GitHub Action configuration for component tests run on every pull request/push to master or release branch.


"run on every push to master or release branch" is an additional detail that needs not be mentioned here. It also necessitates more places to be changed if we ever decide to change the practice.

docs/process.md

wkurniawan07 · 2021-02-07T15:14:28Z

.github/workflows/lnp.yml

+      - name: Start App Engine
+        run: ./gradlew appengineStart
+      - name: Start Tests
+        run: ./gradlew lnpTests


Currently this will not pass in GitHub Actions without also incorporating the fixes from fb8177c.

Ah I see, okay updated based on the commit

…s into finalize-migration

wkurniawan07

LGTM

rrtheonlyone changed the title ~~Finalize Migration to Github Actions~~ [#10874] Finalize Migration to Github Actions Jan 1, 2021

madanalogy added the s.Ongoing The PR is being worked on by the author(s) label Jan 8, 2021

rrtheonlyone force-pushed the finalize-migration branch from 4de4ebd to 8eca20c Compare January 9, 2021 14:28

rrtheonlyone requested review from wkurniawan07 and madanalogy January 10, 2021 11:36

rrtheonlyone added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Jan 10, 2021

wkurniawan07 requested changes Jan 10, 2021

View reviewed changes

wkurniawan07 added s.Ongoing The PR is being worked on by the author(s) and removed s.ToReview The PR is waiting for review(s) labels Jan 18, 2021

rrtheonlyone added 8 commits February 7, 2021 09:43

Delete files pertaining to TRAVIS CI

bf32f87

Remove isTravis/isAppveyor from build.gradle

53ebbf3

Update documentation + status badge in README

1ddacf6

Remove appveyor file

a127660

split workflow files

f18934c

update README

5e611be

Updated workflow files

20c4db6

Updated docs

8f2e949

Updated README.md

a5e7078

rrtheonlyone force-pushed the finalize-migration branch from 3fbc362 to a5e7078 Compare February 7, 2021 10:26

rrtheonlyone added 2 commits February 7, 2021 18:34

Rename Github -> GitHub

9c06862

Merge branch 'master' into finalize-migration

56a58a0

rrtheonlyone requested a review from wkurniawan07 February 7, 2021 14:51

wkurniawan07 requested changes Feb 7, 2021

View reviewed changes

rrtheonlyone added 3 commits February 7, 2021 23:54

Update docs

98c9f10

Update variables in LNP tests

d398e9e

Merge branch 'finalize-migration' of github.com:rrtheonlyone/teammate…

3a5c1db

…s into finalize-migration

rrtheonlyone requested a review from wkurniawan07 February 7, 2021 16:28

wkurniawan07 approved these changes Feb 7, 2021

View reviewed changes

rrtheonlyone added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.Ongoing The PR is being worked on by the author(s) labels Feb 7, 2021

rrtheonlyone merged commit c4ba7a0 into TEAMMATES:master Feb 7, 2021

rrtheonlyone deleted the finalize-migration branch February 7, 2021 17:08

madanalogy added this to the V7.10.0 milestone Feb 8, 2021

madanalogy added the c.DevOps Process-related or build-related improvement and addition label Feb 8, 2021

madanalogy assigned wkurniawan07 Feb 8, 2021

madanalogy removed their request for review February 8, 2021 03:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#10874] Finalize Migration to Github Actions #10905

[#10874] Finalize Migration to Github Actions #10905

rrtheonlyone commented Jan 1, 2021 •

edited

Loading

teammates-bot commented Jan 1, 2021

wkurniawan07 commented Jan 1, 2021

wkurniawan07 commented Jan 2, 2021 •

edited

Loading

madanalogy commented Jan 3, 2021

wkurniawan07 commented Jan 3, 2021

rrtheonlyone commented Jan 3, 2021

wkurniawan07 commented Jan 4, 2021

rrtheonlyone commented Jan 9, 2021

damithc commented Jan 9, 2021

wkurniawan07 commented Jan 10, 2021 •

edited

Loading

damithc commented Jan 10, 2021

rrtheonlyone commented Jan 10, 2021 •

edited

Loading

wkurniawan07 left a comment

wkurniawan07 Jan 10, 2021

rrtheonlyone Feb 7, 2021

wkurniawan07 left a comment

wkurniawan07 Feb 7, 2021

wkurniawan07 Feb 7, 2021

rrtheonlyone Feb 7, 2021

wkurniawan07 left a comment

[#10874] Finalize Migration to Github Actions #10905

[#10874] Finalize Migration to Github Actions #10905

Conversation

rrtheonlyone commented Jan 1, 2021 • edited Loading

teammates-bot commented Jan 1, 2021

wkurniawan07 commented Jan 1, 2021

wkurniawan07 commented Jan 2, 2021 • edited Loading

madanalogy commented Jan 3, 2021

wkurniawan07 commented Jan 3, 2021

rrtheonlyone commented Jan 3, 2021

wkurniawan07 commented Jan 4, 2021

rrtheonlyone commented Jan 9, 2021

damithc commented Jan 9, 2021

wkurniawan07 commented Jan 10, 2021 • edited Loading

damithc commented Jan 10, 2021

rrtheonlyone commented Jan 10, 2021 • edited Loading

wkurniawan07 left a comment

Choose a reason for hiding this comment

wkurniawan07 Jan 10, 2021

Choose a reason for hiding this comment

rrtheonlyone Feb 7, 2021

Choose a reason for hiding this comment

wkurniawan07 left a comment

Choose a reason for hiding this comment

wkurniawan07 Feb 7, 2021

Choose a reason for hiding this comment

wkurniawan07 Feb 7, 2021

Choose a reason for hiding this comment

rrtheonlyone Feb 7, 2021

Choose a reason for hiding this comment

wkurniawan07 left a comment

Choose a reason for hiding this comment

rrtheonlyone commented Jan 1, 2021 •

edited

Loading

wkurniawan07 commented Jan 2, 2021 •

edited

Loading

wkurniawan07 commented Jan 10, 2021 •

edited

Loading

rrtheonlyone commented Jan 10, 2021 •

edited

Loading