[#9593] Add SauceLabs integration #9597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While @xpdavid will be the reviewer, I'll tag @jacoblipech and @AyushChatto along to pass down some knowledge. |
xpdavid
reviewed
Mar 25, 2019
xpdavid
added
s.Ongoing
wkurniawan07
added
s.ToReview
wkurniawan07
changed the title
xpdavid
approved these changes
Mar 27, 2019
xpdavid
reviewed
Mar 27, 2019
|
While this is ready for merging, putting this on hold until we have more E2E tests. |
wkurniawan07
added
s.OnHold
# Conflicts: # .travis.yml
# Conflicts: # src/test/java/teammates/test/cases/browsertests/MashupPageUiTest.java
wkurniawan07
added
s.DoNotMerge
|
Will be closing this for now. We're more better positioned to actually make use of Saucelabs now, but the integration with GitHub Actions needs to studied first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9593
saucelabsas one of the acceptable browsers in our E2E testsmasterbranch push (not PR) if there areSAUCE_USERNAMEandSAUCE_ACCESS_KEYenv variables set.Caveat:This will break external forks'masterbranch build in Travis (if any are set up) because they do not have the valid username/access key pair to run E2E tests on SauceLabs servers (our Open Sauce account obviously cannot be shared with any contributor).