Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12081] User-friendliness: Add label to text input for essay questions #12140

Merged

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Feb 27, 2023

Part of #12081
Sub-issue: Add label to text input for essay questions

Outline of Solution

Added a recipient attribute to the text question edit answer form component. This facilitates the passing of the recipient from the main question submission form component. Afterwards, this recipient attribute is used to compute the correct aria-label for the text input.

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Feb 27, 2023
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Feb 27, 2023
@zhaojj2209 zhaojj2209 merged commit 965a9fb into TEAMMATES:user-friendliness Feb 27, 2023
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
…ns (#12140)

* Add labels for text question responses

* Another merge conflict
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
…ns (#12140)

* Add labels for text question responses

* Another merge conflict
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
…ns (#12140)

* Add labels for text question responses

* Another merge conflict
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
…ns (#12140)

* Add labels for text question responses

* Another merge conflict
@zhaojj2209 zhaojj2209 self-assigned this Apr 2, 2023
@zhaojj2209 zhaojj2209 added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants