Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12081] User-friendliness: Add labels for MSQ checkboxes #12144

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Feb 28, 2023

Part of #12081
Sub-issue: Add label to MCQ (multiple) question

Outline of Solution

Similar to this PR.

@weiquu
Copy link
Contributor Author

weiquu commented Feb 28, 2023

Not sure about the other question types yet, but seeing as the text questions and MSQ questions use the same solution, I think it's possible to shift the recipient and getAriaLabel() portions into question-edit-answer-form.ts to avoid duplication.

@zhaojj2209
Copy link
Contributor

zhaojj2209 commented Feb 28, 2023

Not sure about the other question types yet, but seeing as the text questions and MSQ questions use the same solution, I think it's possible to shift the recipient and getAriaLabel() portions into question-edit-answer-form.ts to avoid duplication.

Good idea, the aria label can then be changed to "Response for ..." to cover all question types. Let's make this change so that subsequent PRs are made simpler. getAriaLabel() can then be expanded to cover all possible cases of recipient as we cover the remaining question types.

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Feb 28, 2023
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Feb 28, 2023
@zhaojj2209 zhaojj2209 merged commit 8b76ab7 into TEAMMATES:user-friendliness Feb 28, 2023
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
* Add labels for MSQ checkboxes

* Shift to question edit form
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
* Add labels for MSQ checkboxes

* Shift to question edit form
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
* Add labels for MSQ checkboxes

* Shift to question edit form
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
* Add labels for MSQ checkboxes

* Shift to question edit form
@zhaojj2209 zhaojj2209 self-assigned this Apr 2, 2023
@zhaojj2209 zhaojj2209 added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants