[refact] 주석 추가 및 refact #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 5, 2023 11:47
const, duplicate interpolation, naming convention 예외처리, event routing 추가, duplicate binding 제거
중첩 라우팅 수정, const, 안쓰는 변수, import 삭제
mypage binding 삭제(controller 미사용으로 삭제) cosnt, import 구문, 주석 추가
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
로그인이 구현된다면 그 이후에 AuthService가 init되며 mypage에 해당하는 api를 호출해야기 때문에 loginBinding에서 삭제하였습니다! 아마 전에 이슈는 main, home binding이 혼용되어 사용되어서 발생한 문제인 것 같습니다.
(login binding에서 AuthService를 호출시, 로그인 이전에 회원정보를 get하는 것이기 때문에 로직상 오류가 있습니다. 현재는 mock jwt token을 사용하기때문에 가능했었던 로직이라 주석 처리하였습니다)