Use psr-4 #43

btry · 2018-04-18T09:05:22Z

One file per class.

Reference: #8

btry · 2018-04-18T13:14:55Z

In this PR I'm splitting the code to have one file per class. In the same time I'm updating the headers in each file.

I wish you review the headers to ensure I don't miss any important information related to the history of the project. I want to keep credits to all main contributors. Please read the following commit, and feedback.

612d138

btry · 2018-04-18T13:57:00Z

@ajsb85 @DIOHz0r please review the headers too while waiting for feedback from previous maintainers

DIOHz0r · 2018-04-18T16:56:59Z

tests/bootstrap.php

+ * ------------------------------------------------------------------------------
+ * @author    Rodney Rehm <rodney.rehm@medialize.de>
+ * @author    Christian Kruse <cjk@wwwtech.de>
+ * @author    Thierry Bugier


Aren't you going to add your email?

I choosed to not put my email.

One can contact me with the bug tracker of the repo (currently github) or via the company I work for. I like dark themes, I fear spam and groupies (if this exists for developers...) :D

https://github.com/flyve-mdm/glpi-plugin/blob/develop/inc/agent.class.php#L24

@btry You can add the email of teclib contact@teclib.com

using this email address disturbs me: it is not intended to receive messages related to development. You won, I'll disclose my email ! I'll forward spam to you ;)

DIOHz0r · 2018-04-18T16:58:09Z

tests/EmptyElementsTest.php

+ * SOFTWARE.
+ *
+ * ------------------------------------------------------------------------------
+ * @copyright Copyright © 2018 Teclib


No authors here?

I only have a pseudonym from git blame. However I choosed to add a pseudonym for an other file, then I'll add it here too.

rodneyrehm · 2018-04-18T18:15:52Z

LGTM :)

btry · 2018-04-19T12:58:25Z

Thank you all for your feedback. I'll merge asap and continue work. Switch to PSR-4 is a BC.

This is the opportunity to change the name of the package (see #27).

BREAKING CHANGE: switching to PSR-4 may impact the way to load the library Signed-off-by: Thierry Bugier <tbugier@teclib.com>

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

fix TECLIB#27 Signed-off-by: Thierry Bugier <tbugier@teclib.com>

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

ajsb85 · 2018-04-19T15:22:12Z

composer.json

@@ -3,10 +3,10 @@
    "description": "Library for reading and writing Apple's CFPropertyList (plist) files in XML as well as binary format.",
    "keywords": ["plist"],


Core Foundation, CFPropertyList, plist, apple, xml, binary

ajsb85 · 2018-04-19T15:30:56Z

composer.json

+         "name": "Thierry Bugier",
+         "email": "tbugier@teclib.com"
+     }
+ ],
    "support": {


"irc": "irc://irc.freenode.org/flyve-mdm",
"email": "contact@teclib.com",
"docs": "http://teclib.github.io/CFPropertyList/",
"rss": "https://teclib.github.io/CFPropertyList/feed.xml"

done ,except irc, as we discussed

ajsb85 · 2018-04-19T15:32:19Z

composer.json

+        },
+        {
+         "name": "Thierry Bugier",
+         "email": "tbugier@teclib.com"


"role": "developer"

ajsb85 · 2018-04-19T15:32:26Z

composer.json

@@ -16,15 +16,19 @@
        {
            "name": "Rodney Rehm",
            "email": "mail+github@rodneyrehm.de"


"role": "developer"

ajsb85 · 2018-04-19T15:58:14Z

composer.json

@@ -1,30 +1,40 @@
 {
    "name": "rodneyrehm/plist",
    "description": "Library for reading and writing Apple's CFPropertyList (plist) files in XML as well as binary format.",
-    "keywords": ["plist"],
+    "keywords": ["Core Fouondation", "CFPropertyList", "plist", "apple", "xml", "binary"],


Core Foundation*

ajsb85 · 2018-04-19T15:59:13Z

composer.json

+        "issues": "https://github.com/TECLIB/CFPropertyList/issues",
+        "source": "https://github.com/TECLIB/CFPropertyList",
+        "email": "contact@teclib.com",
+        "docs": "http://teclib.github.io/CFPropertyList/",


http://teclib.github.io/CFPropertyList/howtos/

ajsb85 · 2018-04-19T15:59:17Z

composer.json

    "type": "library",
-    "homepage": "https://github.com/rodneyrehm/CFPropertyList",
+    "homepage": "https://github.com/TECLIB/CFPropertyList",


http://teclib.github.io/CFPropertyList/

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

btry added refactor style labels Apr 18, 2018

btry self-assigned this Apr 18, 2018

btry requested a review from DIOHz0r April 18, 2018 09:05

btry force-pushed the feature/refactor_psr4 branch from c50fcd8 to c3bed1e Compare April 18, 2018 09:26

ajsb85 self-requested a review April 18, 2018 09:26

btry force-pushed the feature/refactor_psr4 branch from c3bed1e to f84ca64 Compare April 18, 2018 09:28

ajsb85 added this to the 3.0 milestone Apr 18, 2018

btry changed the title ~~Use psr-4~~ WIP Use psr-4 Apr 18, 2018

btry mentioned this pull request Apr 18, 2018

Add a example 07 #37

Merged

DIOHz0r reviewed Apr 18, 2018

View reviewed changes

btry force-pushed the feature/refactor_psr4 branch from 612d138 to 52ef651 Compare April 19, 2018 12:54

btry force-pushed the feature/refactor_psr4 branch 6 times, most recently from b1a4684 to b410467 Compare April 19, 2018 15:00

btry changed the base branch from master to develop April 19, 2018 15:05

btry mentioned this pull request Apr 19, 2018

Code style #47

Merged

btry added 4 commits April 19, 2018 17:30

refactor: use psr-4

026d191

BREAKING CHANGE: switching to PSR-4 may impact the way to load the library Signed-off-by: Thierry Bugier <tbugier@teclib.com>

docs: update source headers

2a4ebea

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

build(composer): raise minimal PHP version to 5.6, update github URLs

19942fc

fix TECLIB#27 Signed-off-by: Thierry Bugier <tbugier@teclib.com>

test: correct unit tests

8a28ffc

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

btry force-pushed the feature/refactor_psr4 branch from b410467 to 8a28ffc Compare April 19, 2018 15:31

ajsb85 suggested changes Apr 19, 2018

View reviewed changes

btry force-pushed the feature/refactor_psr4 branch from 46b39d7 to 7d3c5bf Compare April 19, 2018 15:47

ajsb85 suggested changes Apr 19, 2018

View reviewed changes

btry force-pushed the feature/refactor_psr4 branch 2 times, most recently from 35abfce to fd800d1 Compare April 19, 2018 20:07

docs: add metadata to the package

ea562c9

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

btry force-pushed the feature/refactor_psr4 branch from fd800d1 to ea562c9 Compare April 19, 2018 20:08

btry requested a review from ajsb85 April 19, 2018 20:09

ajsb85 approved these changes Apr 19, 2018

View reviewed changes

ajsb85 merged commit e9f6d67 into TECLIB:develop Apr 19, 2018

btry changed the title ~~WIP Use psr-4~~ Use psr-4 Apr 19, 2018

btry deleted the feature/refactor_psr4 branch April 20, 2018 12:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use psr-4 #43

Use psr-4 #43

btry commented Apr 18, 2018 •

edited by ajsb85

Loading

btry commented Apr 18, 2018

btry commented Apr 18, 2018 •

edited

Loading

DIOHz0r Apr 18, 2018

btry Apr 18, 2018

ajsb85 Apr 18, 2018

btry Apr 19, 2018

DIOHz0r Apr 18, 2018

btry Apr 18, 2018 •

edited

Loading

rodneyrehm commented Apr 18, 2018

btry commented Apr 19, 2018

ajsb85 Apr 19, 2018

ajsb85 Apr 19, 2018

btry Apr 19, 2018

ajsb85 Apr 19, 2018 •

edited

Loading

ajsb85 Apr 19, 2018

ajsb85 Apr 19, 2018

ajsb85 Apr 19, 2018

ajsb85 Apr 19, 2018

		@@ -3,10 +3,10 @@
		"description": "Library for reading and writing Apple's CFPropertyList (plist) files in XML as well as binary format.",
		"keywords": ["plist"],

Use psr-4 #43

Use psr-4 #43

Conversation

btry commented Apr 18, 2018 • edited by ajsb85 Loading

btry commented Apr 18, 2018

btry commented Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btry Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

rodneyrehm commented Apr 18, 2018

btry commented Apr 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajsb85 Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btry commented Apr 18, 2018 •

edited by ajsb85

Loading

btry commented Apr 18, 2018 •

edited

Loading

btry Apr 18, 2018 •

edited

Loading

ajsb85 Apr 19, 2018 •

edited

Loading