Further clean-up of the CETEIcean.css #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubinsky
added a commit
to opentorah/alter-rebbe.org
that referenced
this pull request
Jun 17, 2020
(which includes one small change I asked for and removal of the `table` behaviour) *and* my pull request TEIC/CETEIcean#35: - style TEI tables using `display` values `table`, `table-row`, `table-cell`; - added `.js` extension to the imported module names; my custom `tei.scss`: - lower-cased TEI element names; - style TEI tables as HTML tables are styled by `minima`; - semicolon cleanup; - do not use removed addStyle(); - names aligned with CETEIcean;
|
@hcayless @raffazizzi I left only uncontroversial cleanup in this pull request; please review :) |
raffazizzi
reviewed
Jun 18, 2020
test/CETEIcean.css
Outdated
Comment on lines
900
to
916
|
|
||
| /* styles for HTML shell and HTML elements in TEI (e.g.,<a> and <img>) */ | ||
| html > body { | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
| html { | ||
| margin: 0; | ||
| padding: 0; | ||
| margin-left: 2em; | ||
| margin-right: 4em; | ||
| padding: 2.5em; | ||
| font-family: "Lucida Grande", "Cardo", "Arial Unicode MS","Galilee Unicode Gk", "New Athena Unicode", "Athena Unicode", "Palatino Linotype", "Titus Cyberbit Basic", "Vusillus Old Face", "Alphabetum", "Galatia SIL", "Code 2000", "GentiumAlt", "Gentium", "Minion Pro", "GeorgiaGreek", "Vusillus Old Face Italic", "Everson Mono", "Aristarcoj", "Porson", "Legendum", "Aisa Unicode", "Hindsight Unicode", "Caslon", "Verdana", "Tahoma"; | ||
| font-size: 12pt; | ||
| background-color: white; | ||
| color: #292929; | ||
| } |
There was a problem hiding this comment.
I know (from experience) that having this is frustrating, but this CSS file is mostly meant as an example style that works out of the box. I would slightly prefer to keep it here so that a CETEI rendering with default settings looks good and have advanced users either modify this file for themselves or override in a separate CSS.
There was a problem hiding this comment.
Or to work with your solution of splitting this into two CSS files: we could make CETEIcean.css include html.css and tei.css (replaces CETEIcean.css). @hcayless thoughts?
`CETEIcean.css`: - added `yi` to the `rtl` list; - added `ru` and `pl` to the `ltr` list; - lower-cased overlooked TEI element names; - added `tei-` prefix to the overlooked TEI element names; - removed spurious space; - merged two `tei-table` rules into one;
|
@raffazizzi Rolled back splitting of the |
raffazizzi
approved these changes
Jun 19, 2020
dubinsky
added a commit
to opentorah/alter-rebbe.org
that referenced
this pull request
Jun 21, 2020
(which includes one small change I asked for and removal of the `table` behaviour) *and* my pull request TEIC/CETEIcean#35: - style TEI tables using `display` values `table`, `table-row`, `table-cell`; - added `.js` extension to the imported module names; my custom `tei.scss`: - lower-cased TEI element names; - style TEI tables as HTML tables are styled by `minima`; - semicolon cleanup; - do not use removed addStyle(); - names aligned with CETEIcean;
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tei-prefix to some TEI element names that were overlooked;tei-tablerules into one;yito thertllist;ruandplto theltrlist;Removed overlooked uses of removed addStyle() from the examples.
resolves #34