-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n="added gathering" in XML examples #1816
Comments
Definitely a typo. Underscore or camel case addedGathering if keeping that term. Whether it is a gathering or not one can't really tell from that markup. |
Maybe "quire" would be the more common term. But given that a quire was added here, what I had taken for granted: Again, would you store this information in |
I think gathering and quire are both used depending on school of description (and print vs mss) so that bothers me less. I mean we have gb as gathering beginning in the tei as well which is at least consistency. But the free text in the n attribute is definitely something I'd consider a bug even if others do not. Must do a check for all |
I personally don't like these blanks either, but here I read:
Anyway, is "added gathering" a "number (or other label)"? Maybe I just don't understand what "label" is for in this context. Please forgive my stubbornness. |
Yes. I think that is also not good. I would have |
I don't see any problem here. |
And, for that matter, "added gathering" is a perfectly reasonable value for 1-∞ of teidata.word. (@jamescummings wants teidata.word to be teidata.token, but it was not intended that way.) |
Sure, I'd feel better if that was the case but accept it is not. I have a distinct memory of council several years ago deciding at some point that while we wouldn't change the datatype we would stop exemplifying using spaces in
Generally I'm of the opinion where someone wants a truly textual label then really they should be using |
Fixed in ca4994b by adding dash to eliminate space |
See https://github.com/search?q=org%3ATEIC+%22added+gathering%22&type=Code.
@jamescummings thinks that this is only a typo for
n="added_gathering"
(with an underscore to make it one attribute value).But do you really think that
added gathering
is a good value for@n
?The text was updated successfully, but these errors were encountered: