Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEI example is old-formatted #2314

Closed
kzhr opened this issue Jun 19, 2022 · 5 comments
Closed

TEI example is old-formatted #2314

kzhr opened this issue Jun 19, 2022 · 5 comments

Comments

@kzhr
Copy link

kzhr commented Jun 19, 2022

A TEI example cited below seems to be old-formatted and poorly displayed. I'm not sure what it should be.

https://tei-c.org/release/doc/tei-p5-doc/en/html/DI.html#index-egXML-d54e79590

A bit confusing is that this example lacks a source citation. If I remember correctly, it should have a source citation in early 2020, but I can't find recent changes around here.

@sydb
Copy link
Member

sydb commented Jun 19, 2022

Good grief! This example is FUBAR. Need to dig through old versions of DI to see if a version that is not messed up can be found. Will try to do that early this week.

(Thank you, @kzhr !)

@sydb
Copy link
Member

sydb commented Jun 19, 2022

(DI-PrintDictionaries.xml line 3038.)

@lb42
Copy link
Member

lb42 commented Jun 19, 2022

It's not an example of TEI encoding, nor is it "FUBAR" ! (not an expression I would have expected from Syd ) It's an example of a non-TEI XML encoding which can't be transferred directly without using entryFree. That's what the surrounding text says anyway. If there;s anything to fix here, it's the formatting. Maybe wrapping this in a CDATA section would be a good idea?

@lb42
Copy link
Member

lb42 commented Jun 19, 2022

P.S. And there is a source citation too: but it's been given as a <ref> following the example instead of on the @source attribute

@sydb
Copy link
Member

sydb commented Jun 19, 2022

Indeed, @lb42, good point. I just read the prose and came back here to say essentially the same thing, and found you beat me to it!

I think this example should probably be wrapped in an <eg> (rather than <egXML>), using the @source attribute as @lb42 points out. Using a CDATA marked section (as was the case before 2007-09-29) instead of entity references would be my preference, but someday some process will convert it to entity references, anyway. (Or so says the pessimist in me.)

sydb added a commit that referenced this issue Oct 20, 2022
Per my suggestion on the ticket, changed example of non-XML encoding from 'egXML' to 'eg', and moved citation to its source= attr.
Note: The little anchor that shows up for the “link-to-me” feature is the wrong character (i.e., is different than the one used for 'egXML's); and the “bibliography” link is not showing up. Both of these are Stylesheets problems, and neither one should prevent us from incorporating this change, IMHO.
@sydb sydb mentioned this issue Oct 20, 2022
@peterstadler peterstadler added this to the Guidelines 4.5.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants