added <fLib> and <fvLib> to <fsdDecl> as per #1726 #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the respective Guidelines chapter are yet to do
|
Missed the notification. Will review during the coming weekend. |
|
pinging @bansp for review ;) |
jamescummings
approved these changes
May 8, 2019
|
@peterstadler Agreed and merged by council subgroup. Please test to make sure it is good and then close original ticket (#1726) with reference to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I duly implemented the suggested changes from #1726, i.e. added a new class
model.fsdDeclPartand made<fLib>,<fsDecl>,<fsdLink>,<fvLib>members of this class.The content model of
<fsdDecl>got replaced by a reference to this new class.