Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on 567 #2021

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Work on 567 #2021

merged 2 commits into from
Feb 17, 2021

Conversation

sydb
Copy link
Member

@sydb sydb commented Aug 6, 2020

This change implements 567 by changing the content models of the following elements as per the description on the ticket. This fix has a non-backward compatible change: a member of model.milestoneLike is no longer allowed as the only child of <listBibl>. I consider the fact that such was allowed a corrigible error. (For supporting evidence I note that there are no examples of it in the Guidelines, nor am I aware of any prose discussing what the BLEEP it would mean.)

I did not remove <listRelation> from model.biblPart, per my comment on the ticket of 2017-11-20, to wit that:

  • the (only) effect would be to remove <listRelation> as a possible child of <bibl>;
  • that would obviously break backward compatibility;
  • <bibl>s can clearly have relations to at least other bibliographic items (n.b. <relatedItem>), if not people, places, and things.

Thus I think if we want to remove <listRelation> from model.biblPart, that would require another ticket and a separate discussion.

I did not change any examples that had <relation> as a direct child of <listSomething>, because there were none.

Elements changed:

  • <listBibl>
  • <listEvent>
  • <listNym>
  • <listObject>
  • <listOrg>
  • <listPerson>
  • <listPlace>
  • <listRelation>

@lb42
Copy link
Member

lb42 commented Aug 6, 2020

A bibl containing only milestone like elements and text is entirely possible. You might want to indicate formatting only. Please think again.

@sydb
Copy link
Member Author

sydb commented Aug 6, 2020

Sorry, @lb42, that was my fault … the comment should have said “listBibl”, not “bibl”. While you are obviously correct that <bibl> should be allowed to have text & milestones (one wonders why not text & model.global, though), I think you will agree that a <listBibl> should have at least one bibl-like-thing in it.
I will see if I can edit the comment above …
Yup. Comment edited, which means future readers will, at first blush, think we are being bizzarre.

Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look appropriate and my local build of the schemas was successful – thanks @sydb

P5/Source/Specs/listBibl.xml Show resolved Hide resolved
@peterstadler peterstadler removed the request for review from hcayless February 10, 2021 15:44
@hcayless hcayless merged commit 6462761 into dev Feb 17, 2021
@peterstadler peterstadler deleted the sydb-567 branch February 17, 2021 16:44
hcayless added a commit that referenced this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants