-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated jTEI ODD with @see attributes #2057
Conversation
TEIC#2046 some additional minor fixes to error reports
<!-- [PL] forename and surname are very much western habits. Ethiopian colleagues do not have this habit, for example. | ||
why not allow all what is possible in name? I also do not see constraints here in the ODD about this. | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PietroLiuzzo I'm open to the idea, but the (equally Western-centric) Lodel publication platform does expect surnames and forenames for all contributors (https://tei-openedition.readthedocs.io/en/latest/tei.teiHeader.html#auteurs-editeurs-traducteurs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the example there has name without further specification, which would be already good
<author>
<name>Marin Dacos</name>
</author>
this would be ok for us, and I did not find a rule in the schema requiring that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed, too... and have tested with the Lodel publication platform, which does seem to accept just <name>
, and will then index the last token as surname, and all the rest as forename. So I can confirm <forename>
and <surname>
are not mandatory for the publication system, although they will provide for better control over the indexing of names in the Lodel publication platform (with all apologies for the non-descriptive markup angle of these remarks).
On further investigation, the jTEI schema doesn't require <forename>
and <surname>
either, so it's just the prose description that is over-specified. I do think it's worth mentioning that if name components can be distinguished, they should preferably be a) placed in the order "forename - surname", and b) tagged explicitly with <forename>
and <surname>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be in favour of making <forename>
and <surname>
mandatory. I'm constantly finding holes in transformation code that assumes the surname is a single token when quite frequently it's a double-barrelled name with no hyphen (Ralph Vaughan Williams, Andrew Lloyd Webber, John Maynard Smith, Kristin Scott Thomas, Helena Bonham Carter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the way of putting it of @rvdb last comment !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not mandate or assume order of surname forename, unless you think Zedong Mao
is how Mao Zedong
should appear in jTei. There is a Stylesheets issue discussing this already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvdb (and @PietroLiuzzo and @martindholmes and @duncdrum) —
The main gist of this PR is the addition of @see
attriubtes to the <sch:assert>
elements, which seems like a good idea to me. But not one reviewer has approved it over the issue of a comment relating to the encoding of names. Can we perhaps yank that comment, make another ticket for it, and approve the rest of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fork will have to be refreshed too, because the jTEI ODD seems to have moved on since the PR was originally created.
Council is reviewing pull requests now. @PietroLiuzzo do you want us to go ahead and merge this? |
Would be nice, thanks! For the names I will make another ticket
|
@PietroLiuzzo could you please resolve the conflict in tei_jtei.odd so we can merge? |
@PietroLiuzzo to open a new ticket to discuss the fate of his controversial comment on names. |
#2046 some additional minor fixes to error reports
#2046
some additional minor fixes to error reports