Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prose and added deprecation information for ´superEntry´ element #2532

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

trishaoconnor
Copy link
Contributor

Added deprecation information to the <superEntry> element spec page and updated the prose and examples related to the <superEntry> element accordingly.

@trishaoconnor trishaoconnor requested review from torstenroeder and removed request for sabineseifert March 7, 2024 20:40
European subgroup changed wording to remove implication that a type= attribute is necessary when using
an entry element to do what superEntry does now, and to exmplify both no type= attribute and a type=
attribute of "wordFamily".
Copy link
Contributor

@torstenroeder torstenroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this together and think it is great now.

@GusRiva GusRiva merged commit 17fdd53 into dev Mar 16, 2024
3 checks passed
@GusRiva GusRiva deleted the trishaoconnor_2488 branch March 16, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants