Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversions endpoint returns text/xml;charset=ISO-8859-1 header info #26

Closed
peterstadler opened this issue Sep 28, 2022 · 1 comment
Closed

Conversions endpoint returns text/xml;charset=ISO-8859-1 header info #26

peterstadler opened this issue Sep 28, 2022 · 1 comment
Assignees
@anneferger
Labels
bug Something isn't working

Comments

@peterstadler
Copy link
Member

while the returned file states <?xml version="1.0" encoding="UTF-8"?>

It seems this only affects the Conversions endpoint via GET request.

Since the encoding info is optional it could simply be dropped, otherwise "UTF-8" seems to be a good default.
@peterstadler peterstadler added the bug Something isn't working label Sep 28, 2022
@peterstadler
Copy link
Member Author

peterstadler commented Sep 28, 2022 •
edited
Loading

Wait, the Validation endpoint is also affected?!

anneferger added a commit that referenced this issue Sep 28, 2022
@anneferger
Merge pull request #30 from TEIC/feature/small-utf-8-changes
e016be9 
set GET encoding correctly fixes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anneferger anneferger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterstadler @anneferger