nmake compatibility #39
Conversation
| LIBRARY_SRCS = gsw_oceanographic_toolbox.c \ | ||
| gsw_saar.c | ||
|
|
||
| # \ |
There was a problem hiding this comment.
How does this block starting with line 10 work? Under what conditions is it active?
There was a problem hiding this comment.
nmake and make uses different syntax for ifdef, endif etc. these directives can raise a syntax error. Since nmake does not support multiline comments for nmake case line 11,12 and so on will be active lines but for make case they will be interpreted as comment block (except line 12).
By default nmake searches TOOLS.ini for definitions, by using this small trick we can include TOOLS.gcc file safely and can set all definitions for make case
|
I probably have a similar background re windows experience as @ocefpaf, I think we'll need to rely on contributions like this for windows support. I'd say let's get CI setup so we have some assurances that downstream projects won't break and we can merge. |
@egecetin I pushed the GitHub Action test to your branch and it is passing! Thanks!! |
Thanks for your efforts in CI which makes this PR more meaningful. I think it can be merged now safely. |
|
Thank you! |
Changed Makefile to use the same file for make (Linux) and nmake (Windows)
Additionally gsw_check_functions.c array definitions changed because of Compiler Error C2131.