Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gibbs and gibbs_ice via ufunc wrapping. #134

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Add gibbs and gibbs_ice via ufunc wrapping. #134

merged 4 commits into from
Jun 21, 2023

Conversation

efiring
Copy link
Member

@efiring efiring commented Apr 11, 2023 •
edited
Loading

Closes #131, as an alternative to #132.

@efiring efiring marked this pull request as draft April 11, 2023 01:04
@efiring efiring marked this pull request as ready for review April 17, 2023 01:50
ocefpaf
ocefpaf approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efiring this one looks good to me. Merge?

@efiring efiring merged commit 3c73617 into TEOS-10:main Jun 21, 2023
@efiring efiring deleted the gibbs branch June 21, 2023 17:38
@efiring efiring mentioned this pull request Jun 21, 2023
Closed
@ocefpaf ocefpaf mentioned this pull request Jun 22, 2023
Closed
@ocefpaf
Copy link
Member

ocefpaf commented Jun 22, 2023

I'm minting a new release to ship this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add missing functions (gibbs etc)
2 participants
@efiring @ocefpaf