Appveyor #3
Appveyor #3
Conversation
|
It's not clear to me how to add appveyor and Travis. I see where they are listed and can be configured with respect to access permissions, but I haven't found a place to activate them. |
If you already have an account on both, if not you can just login with your GitHub, you can navigate to: https://travis-ci.org/efiring/python-gsw and a button to activate it should be there. For AppVeyor you need to go to: https://ci.appveyor.com/projects/new and search |
|
It should be active now. I triggered a build and got |
AppVeyor just staeted, see above, here but Travis-CI did not. |
|
I have to run now, and won't have much time until late afternoon. I
will get Travis enabled then.
…On 2017/04/04 8:15 AM, Filipe wrote:
It should be active now. I triggered a build and got
AppVeyor just staeted, see above, here but Travis-CI did not.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFMhXJSbo9Vqyi3ZcrtSjTxXBvoxoyZks5rsojMgaJpZM4MzLM7>.
|
There is no rush. I am working on the docs next and hopefully I'll have some news on the Windows front too. |
|
I think the |
|
Awesome! Thanks @gillins! I will try the |
|
I tried setting the language in the commit: ocefpaf@6fb5c31
commit: ocefpaf@6a4c264 I tried a few combinations of AppVeyor's commit: ocefpaf@a7346e2 |
|
What a mess! MSVC is hopeless for C99 including complex. It looks like the complex numbers are used only in the ice functions, so one option would be to patch the C with preprocessor commands that disable the ice functions and the complex declarations when MSVC is being used. That is not an appealing prospect. An even less-appealing option would be to reimplement all of the things presently using complex. What we really want is revitalization of mingwpy, which seems to have stalled a year ago. I don't know what to do; I will ponder this some more. |
That would be ideal.
My two cents would be to remove those functions for now with a patch. |
|
I would like to try a patch that simply changes the complex declarations and initializations in the MSVC case, as suggested in the answer here: http://stackoverflow.com/questions/22991409/compiling-c-code-in-visual-studio-2013-with-complex-h-library. It seems like this has a reasonable chance of working on Python 3.5 and 3.6. What is the simplest way for me to be able to try this? |
I just resolved the conflicts. I guess that you can merge this and use the |
|
I have made the commit locally, on a new branch, but I can't push that branch to the repo: I'm baffled. I was assuming I would be able to push it, and that this would trigger the Appveyor and Travis builds. |
|
Can you do |
|
On 2017/04/05 11:29 AM, Filipe wrote:
Can you do |git push --set-upstream origin msvc_complex|? I am a bit
lost there...
That worked, thank you. It also set up the PR mechanism, so I turned it
into a PR, and the travis build failed. I will look at that now.
|
This builds on top of #2 and add the
AppVeyormachinery for testing. You can see the result at: https://ci.appveyor.com/project/ocefpaf/python-gswc/build/1.0.9The compiler is not happy but maybe those are easy to fix for those with Windows experience.
@gillins if you are not too busy can you give me some advice where I could start?