Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update canonical SEG-Y header field names in SEGY standards revisions 0 and 1 #82

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

tasansal
Copy link
Contributor

@tasansal tasansal commented Apr 8, 2024

The field names in trace header fields for SEGY standards rev 0 and 1 have been revised. In revision 1, "x_coordinate" has been changed to "cdp_x", "y_coordinate" to "cdp_y", etc. For revision 0, "cdp_ens_no" is now "ensemble_no" and "vert_sum" is updated to "vertical_sum". These changes aim to enhance consistency with standards.

The field names in trace header fields for SEGY standards rev 0 and 1 have been revised. In revision 1, "x_coordinate" has been changed to "cdp_x", "y_coordinate" to "cdp_y", etc. For revision 0, "cdp_ens_no" is now "ensemble_no" and "vert_sum" is updated to "vertical_sum". These changes aim to enhance consistency with standards.
@tasansal tasansal added the refactoring Refactoring label Apr 8, 2024
@tasansal tasansal self-assigned this Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (edc43dc) to head (1dd84a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files          38       38           
  Lines        1574     1574           
  Branches      193      193           
=======================================
  Hits         1482     1482           
  Misses         70       70           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasansal tasansal merged commit 3768a14 into main Apr 8, 2024
32 checks passed
@tasansal tasansal deleted the rename-canonical-segy-fields branch April 8, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant