Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fixes for reactions #205

Merged
merged 121 commits into from
Sep 16, 2022
Merged

Conversation

Arseny271
Copy link
Contributor

The guide below provides the flow for creating a perfect pull request to the Telegram X Repository. Before submitting your PR, ensure that it complies with the following principles.

Perfect PRs must be:

  • Rational. Explain the changes you've made. Be explicit and describe the changes in a few short, concise sentences.
  • Completed. All changes are properly tested and ready to be merged.
  • Up-To-Date. Your PR is based on the latest commit of the 'main' branch.

When fixing issues, make sure that your PR is:

  • Sufficient. Changes must fix the cause of an issue, not its effects.
  • Separated. Different bug fixes are divided into independent PRs.
  • Linked. If you fix a specific issue, add it to the title and its description to the body.
  • Creating. The fix does not break anything in other interfaces or on specific devices.
  • Consistent. Use the proper design relevant to the issue. If the design is missing, the PR must include at least two screenshots (before and after the changes).

When adding features, expect:

  • Discussion. If you implement a feature that requires a new design for the app, be ready to receive and follow comments or edit suggestions.
  • Dismissal. If the feature design you submitted is below our expectations, if it cripples the UX, or the feature-to-user impact is minor, your PR will be declined. All the features must strictly follow the Telegram X flow – matching the overall quality, stability, and the general style of the app.

Other contributions:

PR types not mentioned above can be considered as well, provided they are rational. For example, optimizations of existing features or the app build time (for this, before/after timing is mandatory). For code refactoring, the code should be clearly improved/simplified/more convenient and is expected to be free of any edge-case bugs.

Good luck and thanks for the contribution!

@vkryl vkryl force-pushed the main branch 2 times, most recently from 7e6f557 to 31a09f5 Compare August 18, 2022 09:57
Copy link

@Toyboygg Toyboygg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

390 173 04

Copy link

@Toyboygg Toyboygg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor desbaneenme de los grupos

``

Copy link

@PacksDistroLA PacksDistroLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@PacksDistroLA PacksDistroLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21:34:34

Copy link

@FaizzJamaludin FaizzJamaludin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as planned

Copy link

@kennywayne85 kennywayne85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agette8
Copy link

Agette8 commented Sep 13, 2022

The guide below provides the flow for creating a perfect pull request to the Telegram X Repository. Before submitting your PR, ensure that it complies with the following principles.

Perfect PRs must be:

  • Rational. Explain the changes you've made. Be explicit and describe the changes in a few short, concise sentences.
  • Completed. All changes are properly tested and ready to be merged.
  • Up-To-Date. Your PR is based on the latest commit of the 'main' branch.

When fixing issues, make sure that your PR is:

  • Sufficient. Changes must fix the cause of an issue, not its effects.
  • Separated. Different bug fixes are divided into independent PRs.
  • Linked. If you fix a specific issue, add it to the title and its description to the body.
  • Creating. The fix does not break anything in other interfaces or on specific devices.
  • Consistent. Use the proper design relevant to the issue. If the design is missing, the PR must include at least two screenshots (before and after the changes).

When adding features, expect:

  • Discussion. If you implement a feature that requires a new design for the app, be ready to receive and follow comments or edit suggestions.
  • Dismissal. If the feature design you submitted is below our expectations, if it cripples the UX, or the feature-to-user impact is minor, your PR will be declined. All the features must strictly follow the Telegram X flow – matching the overall quality, stability, and the general style of the app.

Other contributions:

PR types not mentioned above can be considered as well, provided they are rational. For example, optimizations of existing features or the app build time (for this, before/after timing is mandatory). For code refactoring, the code should be clearly improved/simplified/more convenient and is expected to be free of any edge-case bugs.

Good luck and thanks for the contribution!

You probably welcome

@Agette8
Copy link

Agette8 commented Sep 13, 2022

You don't do well

Copy link

@EDINAM233 EDINAM233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Telegram x 8s still stable and developing fast I don't know why arsenal requested a pull

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@vkryl vkryl merged commit b2d16fb into TGX-Android:main Sep 16, 2022
Copy link

@EDINAM233 EDINAM233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why try to request pull when Telegram X is way better than your peacegram ???BUSH BOEKE ALLEN COURAGE WITNESS E22

@Arseny271 Arseny271 deleted the tgx-contest-round-1-part-2.1 branch January 22, 2024 17:24
@Arseny271 Arseny271 restored the tgx-contest-round-1-part-2.1 branch January 22, 2024 17:24
@Arseny271 Arseny271 deleted the tgx-contest-round-1-part-2.1 branch February 14, 2024 17:33
s3va pushed a commit to s3va/sevatgx that referenced this pull request Apr 27, 2024
This PR provides several bugfixes to the reactions implementation used in Telegram X.

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants