Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat folders: Redesign, Global Filter #602

Merged
merged 22 commits into from
Jun 5, 2024
Merged

Chat folders: Redesign, Global Filter #602

merged 22 commits into from
Jun 5, 2024

Conversation

nikita-toropov
Copy link
Contributor

No description provided.

@nikita-toropov nikita-toropov force-pushed the chat-folders branch 5 times, most recently from 1924fd1 to fbec1d9 Compare May 16, 2024 09:23
t-me-c-2093488272-77

This comment was marked as off-topic.

Sign in to view

t-me-c-2093488272-77

This comment was marked as off-topic.

Sign in to view

aguinaldok4

This comment was marked as off-topic.

Sign in to view

@TGX-Android TGX-Android deleted a comment from aguinaldok4 May 20, 2024
@Mkspy2810
Copy link

devcontainer.json

@qwertann qwertann mentioned this pull request May 21, 2024
Closed
@nikita-toropov nikita-toropov force-pushed the chat-folders branch 3 times, most recently from 871a191 to de5be69 Compare May 22, 2024 19:32
This was referenced May 30, 2024
Closed
Closed
@pdkpv
Copy link

pdkpv commented Jun 1, 2024

Please add the ability to move entities to the archive directly from a folder - this will greatly simplify the organization of entities for the entire account as a whole.

This feature is available in the classic client.

Classic

Screenshot_2024_04_22_13_26_22_980_org_telegram_messenger_web_edit
Screenshot_2024_04_22_13_27_50_970_org_telegram_messenger_web_edit

X

Screenshot_2024_04_22_13_26_01_085_org_thunderdog_challegram_edit
Screenshot_2024_04_22_13_25_49_254_org_thunderdog_challegram_edit

@nikita-toropov
Copy link
Contributor Author

Please add the ability to move entities to the archive directly from a folder - this will greatly simplify the organization of entities for the entire account as a whole.

It is not related to this PR. You feel free to change logic here and open PR.

@xjxsmile xjxsmile mentioned this pull request Jun 5, 2024
Closed
@TGX-Android TGX-Android deleted a comment from Avaladirva Jun 5, 2024
vkryl
vkryl approved these changes Jun 5, 2024
View reviewed changes
app/src/main/java/org/thunderdog/challegram/navigation/ViewPagerTopView.java
Comment on lines +1075 to 1076
c.restore();
c.restore();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: use single restoreToCount call instead

app/src/main/java/org/thunderdog/challegram/ui/SelectChatsController.java Show resolved Hide resolved
app/src/main/java/org/thunderdog/challegram/ui/MainController.java Show resolved Hide resolved
app/src/main/java/org/thunderdog/challegram/ui/ChatFoldersFeatureController.java Show resolved Hide resolved
app/src/main/java/org/thunderdog/challegram/tool/Views.java
Comment on lines +877 to +878
public static int getLeftMargin (View view) {
if (view != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rework in kotlin and move to X-Android module

@vkryl vkryl merged commit fe25a4e into TGX-Android:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-me-c-2093488272-77 t-me-c-2093488272-77 t-me-c-2093488272-77 left review comments

@aguinaldok4 aguinaldok4 aguinaldok4 left review comments

@vkryl vkryl vkryl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikita-toropov @Mkspy2810 @pdkpv @vkryl @aguinaldok4 @t-me-c-2093488272-77