Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application wide settings #36

Merged
merged 15 commits into from
Sep 1, 2020
Merged

Add application wide settings #36

merged 15 commits into from
Sep 1, 2020

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Aug 28, 2020

Fixes #34

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Added package to save application wide settings in database
  • Changed api route 'currentUser' to 'application' to place more data into it
  • Adjust methods to work with the new api
  • Make to logo read it's url from the config
  • Add room limit

Other information

@SamuelWei SamuelWei marked this pull request as draft August 28, 2020 08:20
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #36 into master will increase coverage by 0.28%.
The diff coverage is 82.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     65.76%   66.05%   +0.28%     
- Complexity      229      233       +4     
============================================
  Files            80       81       +1     
  Lines          1110     1137      +27     
  Branches         63       66       +3     
============================================
+ Hits            730      751      +21     
- Misses          363      369       +6     
  Partials         17       17              
Impacted Files Coverage Δ Complexity Δ
app/Http/Middleware/Authenticate.php 100.00% <ø> (ø) 2.00 <0.00> (-2.00)
resources/js/views/App.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../Http/Controllers/api/v1/ApplicationController.php 40.00% <40.00%> (ø) 2.00 <2.00> (?)
resources/js/store/modules/session.js 59.25% <60.00%> (+0.16%) 0.00 <0.00> (ø)
resources/js/components/Room/NewRoomComponent.vue 82.85% <80.00%> (+2.85%) 0.00 <0.00> (ø)
app/Http/Controllers/api/v1/RoomController.php 100.00% <100.00%> (ø) 19.00 <0.00> (+2.00)
...p/Http/Controllers/api/v1/auth/LoginController.php 100.00% <100.00%> (ø) 9.00 <0.00> (-1.00)
app/Http/Resources/User.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
app/User.php 100.00% <100.00%> (ø) 15.00 <3.00> (+3.00)
resources/js/store/index.js 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebed0c...0944297. Read the comment docs.

@SamuelWei SamuelWei marked this pull request as ready for review August 31, 2020 09:31
.env.example Show resolved Hide resolved
app/User.php Outdated Show resolved Hide resolved
config/settings.php Show resolved Hide resolved
resources/js/views/rooms/Index.vue Outdated Show resolved Hide resolved
resources/js/api/auth.js Outdated Show resolved Hide resolved
resources/js/store/modules/session.js Outdated Show resolved Hide resolved
tests/Frontend/components/Room/RoomList.spec.js Outdated Show resolved Hide resolved
@SamuelWei SamuelWei mentioned this pull request Sep 1, 2020
@dsst95 dsst95 self-requested a review September 1, 2020 08:19
@dsst95 dsst95 merged commit 40959f4 into master Sep 1, 2020
@dsst95 dsst95 deleted the 34-application-settings branch October 12, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application settings
2 participants