Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shibboleth #497

Merged
merged 45 commits into from
Sep 27, 2023
Merged

Implement Shibboleth #497

merged 45 commits into from
Sep 27, 2023

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Aug 23, 2023

Fixes #20

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Implement Shibboleth with apache mod _shib
  • Adjust Greenlight v2 migration script to impot social users from Greenlight v2
  • Add database transactions to Greenlight v2 migration script to revert changes on errors
  • Fix error on Greenlight v2 migration, room feature 'Room Authentication' missing
  • Fix error on Greenlight v2 migration, room name too long (truncate room name after max. lenght)

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

app/Auth/Shibboleth/LogoutNotification.wsdl Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (39ddfca) 94.76% compared to head (9cee464) 94.70%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #497      +/-   ##
============================================
- Coverage     94.76%   94.70%   -0.06%     
- Complexity      962     1007      +45     
============================================
  Files           260      272      +12     
  Lines          6303     6481     +178     
  Branches        521      526       +5     
============================================
+ Hits           5973     6138     +165     
- Misses          315      328      +13     
  Partials         15       15              
Files Coverage Δ
app/Auth/ExternalUser.php 100.00% <100.00%> (ø)
app/Auth/LDAP/LDAPProvider.php 65.21% <100.00%> (ø)
app/Auth/Shibboleth/ShibbolethController.php 100.00% <100.00%> (ø)
app/Auth/Shibboleth/ShibbolethProvider.php 100.00% <100.00%> (ø)
app/Auth/Shibboleth/ShibbolethServiceProvider.php 100.00% <100.00%> (ø)
...Shibboleth/ShibbolethSessionDuplicateException.php 100.00% <100.00%> (ø)
...pp/Auth/Shibboleth/ShibbolethSessionMiddleware.php 100.00% <100.00%> (ø)
app/Auth/Shibboleth/ShibbolethUser.php 100.00% <100.00%> (ø)
app/Auth/Shibboleth/SoapServerHandler.php 100.00% <100.00%> (ø)
...p/Http/Controllers/api/v1/auth/LoginController.php 100.00% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/session.php Outdated Show resolved Hide resolved
@SamuelWei SamuelWei marked this pull request as ready for review September 19, 2023 14:23
@SamuelWei SamuelWei merged commit 6e65641 into master Sep 27, 2023
3 of 5 checks passed
@SamuelWei SamuelWei deleted the 20-implement-shibboleth branch September 27, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement shibboleth sso authentication
2 participants