Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise for GCC #392

Merged
merged 17 commits into from
Dec 7, 2022
Merged

Revise for GCC #392

merged 17 commits into from
Dec 7, 2022

Conversation

hwangyeong
Copy link
Contributor

Description

Revised GCC to make it more in line with the idea of his original paper

Checklist

Please feel free to remove inapplicable items for your PR.

  • gcc_mw
  • gcc_dw
  • sampling
  • bug fixed
  • ...

@hwangyeong hwangyeong closed this Dec 7, 2022
@hwangyeong hwangyeong reopened this Dec 7, 2022
cenyk1230
cenyk1230 reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@cenyk1230 cenyk1230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the meaning of first_restart in the random walk function?

@hwangyeong hwangyeong closed this Dec 7, 2022
@hwangyeong hwangyeong reopened this Dec 7, 2022
cenyk1230
cenyk1230 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@cenyk1230 cenyk1230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request successfully implement the GCC model.

@cenyk1230 cenyk1230 merged commit 5b62c61 into THUDM:master Dec 7, 2022
@hwangyeong hwangyeong deleted the last branch December 11, 2022 18:43
@hwangyeong hwangyeong restored the last branch December 11, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenyk1230 cenyk1230 cenyk1230 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwangyeong @cenyk1230