Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SGC-PN model #60

Merged
merged 5 commits into from
Nov 28, 2020
Merged

add SGC-PN model #60

merged 5 commits into from
Nov 28, 2020

Conversation

yaofeng1998
Copy link
Contributor

Based on PairNorm: Tackling Oversmoothing in GNNs (link: https://arxiv.org/abs/1909.12223, source code: https://github.com/LingxiaoShawn/PairNorm)
Contributor: Yao Feng

@cenyk1230
Copy link
Member

Hi @feng-y16,

Thank you for contributing to the CogDL. The model should be also tested. You can add one test in tests/tasks/node_classification.py to ensure the model is covered in the testing. In the meanwhile, you should add the results of the new model to our leaderboard in the README (https://github.com/THUDM/cogdl#semi-supervised-node-classification-with-attributes).

@cenyk1230
Copy link
Member

Are there any ways to add only three datasets (cora-missing, citeseer-missing, and pubmed-missing) and pass the missing rate (0/20/40/60/80/100) as input arguments?

@yaofeng1998
Copy link
Contributor Author

I see. It seems that the dataset classes cannot add arguments to the parser, so I am not sure.

@cenyk1230
Copy link
Member

Sorry, I will try to implement the feature to support dataset arguments.

@cenyk1230
Copy link
Member

Maybe we can add the missing rate argument in the node_classification task and process the data in the __init__ function of node_classification task.

@yaofeng1998
Copy link
Contributor Author

I fixed the issues.

@cenyk1230
Copy link
Member

From the build, it seems you should set missing_rate=-1 in the get_default_args in the test_node_classification.py.

@cenyk1230 cenyk1230 merged commit 5e8ee8d into THUDM:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants