Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of SIGN model #76

Merged
merged 10 commits into from
Dec 15, 2020
Merged

Implementation of SIGN model #76

merged 10 commits into from
Dec 15, 2020

Conversation

hmartelb
Copy link
Contributor

This PR contains the implementation of SIGN: Scalable Inception Graph Neural Networks.

@cenyk1230
Copy link
Member

Hi @hmartelb,

It seems that it lacks some hyper-parameters in the testing.

@hmartelb
Copy link
Contributor Author

Hi @cenyk1230 ,
Is this ready to merge?

@cenyk1230
Copy link
Member

Hi @hmartelb,
It seems that the coverage of the code is not so good (77.89% from https://coveralls.io/builds/35355800). It would be better if the coverage is greater than the current coverage of the cogdl (around 81%).

@cenyk1230 cenyk1230 merged commit 050da77 into THUDM:master Dec 15, 2020
@cenyk1230
Copy link
Member

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmartelb @cenyk1230