Snap 2698 ignoring failing tests in compatibilityTests #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumwale
reviewed
Nov 1, 2018
| extends StatisticsCollectionSuite | ||
| with SharedSnappySessionContext { | ||
|
|
||
| } |
There was a problem hiding this comment.
Do all tests in this suite fail? Won't it be better to keep the class around and mark all as ignored so that we do not miss fixing these.
There was a problem hiding this comment.
There are duplicates. The 2nd one got created by mistake. Hence removing it
1: SnappyStattisticsCollectionSuite and
2: SnappyStatisticsCollectionSuite
|
|
||
| override protected def test(testName: String, testTags: Tag*)(testFun: => Unit) = { | ||
| if (!excluded.contains(testName)) { | ||
| super.test(testName, testTags: _*)(testFun) | ||
| if (ignored.contains(testName)){ |
sumwale
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Ignoring failing tests in compatibilityTests. These tests are tracked seperately as subtasks in https://jira.snappydata.io/browse/SNAP-2263
Patch testing
Ran precheckin and check on compatibilityTests
ReleaseNotes.txt changes
No
Other PRs
No