add phone area data migration #82
Conversation
| PhoneArea::query()->insertOrIgnore([ | ||
| [ | ||
| 'code' => 239, | ||
| 'state_id' => 1, |
There was a problem hiding this comment.
We can't use an ID for State (#16). We have to look it up as we did with Country in the States migration to add the data:
This is because the State ID could be different in the application.
There was a problem hiding this comment.
Sure no problem. I'll change it.
| ->map(function (array $record) use ($now) { | ||
| $stateId = State::fromAbbreviation($record['state_abbreviation'])->getId(); | ||
| unset($record['state_abbreviation']); |
There was a problem hiding this comment.
This is a slick implementation! 
| public static function fromAbbreviation(string $abbreviation): self | ||
| { | ||
| /** @var State $result */ | ||
| $result = static::query()->where('abbreviation', '=', $abbreviation)->firstOrFail(); | ||
|
|
||
| return $result; | ||
| } |
|
@arwaawan3 Could you try breaking this out into 2 separate migrations and see if those last tests pass? |
|
Windows servers must have a limit on how many data rows can be added in a migration. |
|
Oh ok I will split it. |
|
@drewroberts I've split them in two files but I don't like the names of the two classes. If you any suggestions we can change them? |
I think it's great for right now. I'm going to end up moving these files later from |
Ok 👍 |
|
Closes #113 |
Closes #76