Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TGER-46] Require the new test-support as the only dev dependency #22

Merged
merged 1 commit into from
Feb 11, 2021
Merged

[TGER-46] Require the new test-support as the only dev dependency #22

merged 1 commit into from
Feb 11, 2021

Conversation

phuclh
Copy link
Contributor

@phuclh phuclh commented Feb 11, 2021

Add code to phpunit.xml.dist

    <php>
        <env name="DB_CONNECTION" value="testing"/>
        <env name="APP_KEY" value="AckfSECXIvnK5r28GVIWUAxmbBSjTsmF"/>
    </php>

drewroberts
drewroberts approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👻

@drewroberts drewroberts merged commit da12848 into main Feb 11, 2021
@drewroberts drewroberts deleted the omnia/feature/#46-require-test-support-as-dev-dependency branch February 11, 2021 23:15
joshtorres
joshtorres reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@joshtorres joshtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtorres joshtorres joshtorres left review comments

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phuclh @joshtorres @drewroberts