Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of published config file #9

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix name of published config file #9

merged 2 commits into from
Mar 2, 2021

Conversation

pdbreen
Copy link

@pdbreen pdbreen commented Mar 2, 2021

Base package provider is auto-stripping laravel- from config file name which causes this package to break composer auto-discovery w/missing file error.

> @php artisan package:discover --ansi

   ErrorException 

  require(/Users/patrickbreen/tger/testbed/vendor/tipoff/laravel-serpapi/src/../config/serpapi.php): failed to open stream: No such file or directory

@pdbreen pdbreen requested a review from drewroberts March 2, 2021 15:42
drewroberts
drewroberts approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🍍

@drewroberts drewroberts merged commit 1445a5d into main Mar 2, 2021
@drewroberts drewroberts deleted the pdbreen/bugfix/explicit-config-file branch March 2, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdbreen @drewroberts