Make code loadable #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdbreen
commented
Feb 11, 2021
| @@ -13,8 +13,6 @@ class Payment extends BaseModel | |||
| protected $casts = [ | |||
| ]; | |||
|
|
|||
| protected $refund = app('refund'); | |||
There was a problem hiding this comment.
This is not legal PHP - can't use a function in member assignment. I'm updating the checkout packages to require their true dependencies and stumbled on this trying to run tests.
pdbreen
commented
Feb 11, 2021
| @@ -94,7 +92,9 @@ public function generateAmountRefunded() | |||
| */ | |||
| public function requestRefund($amount = null, $method = 'Stripe') | |||
| { | |||
| return $this->refund::create([ | |||
| $refundModel = app('refund'); | |||
There was a problem hiding this comment.
You can add /** @var Model $refundModel */ above and it should be ok. Per discussion yesterday, this package should add an explicit dependency on the refund package and then use the Refund model directly and then work to move that dependency into a service / model interface later.
drewroberts
reviewed
Feb 11, 2021
| @@ -1,5 +1,6 @@ | |||
| <?php namespace TipOff\Payments\Models; | |||
|
|
|||
| use Illuminate\Database\Eloquent\Model; | |||
There was a problem hiding this comment.
Thank you. That makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.