Moving payments migrations models factories to package #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0wik
reviewed
Feb 2, 2021
sl0wik
reviewed
Feb 2, 2021
database/migrations/2020_05_05_100000_create_payments_table.php.stub
Outdated
Show resolved
Hide resolved
joshtorres
approved these changes
Feb 3, 2021
drewroberts
deleted the
feature/moving_payments_migrations_models_factories_to_package
branch
joshtorres
reviewed
Feb 5, 2021
| parent::boot(); | ||
|
|
||
| static::creating(function ($payment) { | ||
| if (empty($payment->creator_id) && auth()->check()) { |
There was a problem hiding this comment.
I think we are moving this out to the Support package per a discussion yesterday. I think @drewroberts said he would put it in HasCreator and HasUpdater traits.
There was a problem hiding this comment.
Yes, I'll have someone go through and update the packages once that trait is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.