Add support for stripe keys in config/env by location and tests for #28 #47
Conversation
| public function getStripePublishableAttribute($value) | ||
| { | ||
| return $value ?? $this->getStripeConfigKey('publishable'); | ||
| } | ||
|
|
||
| public function getStripeSecretAttribute($value) | ||
| { | ||
| return $value ?? $this->getStripeConfigKey('secret'); | ||
| } |
There was a problem hiding this comment.
These attribute getters (and the getStripeConfigKey() helper) is the key logic. If a DB value is set for either of these attributes, its used. Otherwise, it goes to the config. Within the config, it searches for a location specific entry (keyed by location abbreviation). If not configured, then a default key within the config is used. If that's not configured, then there are no stripe keys available and null is returned.
There was a problem hiding this comment.
This is an excellent solution!
|
The fields could be removed from the DB entirely and this would all still work. So, I'll leave that decision to you. |
| * | ||
| * If no prefix is provided, STRIPE_PUBLISHABLE_KEY, STRIPE_SECRET_KEY env values are used | ||
| */ | ||
| 'default' => LocationPaymentSetting::stripeEnvKeyPair(), |
There was a problem hiding this comment.
Also - I'm not sure if using a function to generate the key pairs makes this easier or possibly harder to understand. So, happy to pull it for being more explicit if you want.
pdbreen
changed the title
@pdbreen Let's go ahead and remove them from the database and I don't think we need that table anymore. |
Laravel Cashier Stripe usage is confirmed - #28. Made it a bit more robust and added tests.