Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TGER-60] - remove guarded property #38

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

arwaawan3
Copy link

Closes #37

Comment on lines +20 to +23
"tipoff/support": "^1.2.6"
},
"require-dev": {
"tipoff/test-support": "^1.0"
"tipoff/test-support": "^1.0.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping to the current releases!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry I didn't know about it before

@drewroberts
Copy link
Member

@phuclh Can you issue a new PR on this package to fix the psalm errors in the models?

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Arwa! 🚁

@drewroberts drewroberts merged commit 6d11e2a into main Feb 12, 2021
@drewroberts drewroberts deleted the omnia/feature/#60_remove_property_from_package branch February 12, 2021 20:35
Copy link
Member

@joshtorres joshtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review $guarded from Reviews package
4 participants