Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix review permissions migration #57

Merged
merged 2 commits into from
Mar 10, 2021
Merged

fix review permissions migration #57

merged 2 commits into from
Mar 10, 2021

Conversation

arwaawan3
Copy link

@arwaawan3 arwaawan3 commented Mar 8, 2021 •
edited
Loading

I reopened this one and removed extra permissions from the migration. If the previous one was correct then we need to instead update the policies.

@arwaawan3
Copy link
Author

arwaawan3 commented Mar 9, 2021 •
edited
Loading

Closes #52
Closes #58

drewroberts
drewroberts approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Thank you! 🍓

@drewroberts drewroberts merged commit cc74073 into main Mar 10, 2021
@drewroberts drewroberts deleted the omnia/feature/52-Fix-Permissions branch March 10, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

@joshtorres joshtorres Awaiting requested review from joshtorres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwaawan3 @drewroberts @arwaawan