Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Search Console to check keyword search volumes #106

Merged
merged 5 commits into from
Apr 23, 2021

Conversation

phuclh
Copy link
Contributor

@phuclh phuclh commented Apr 21, 2021

Add ability to check keyword search volumes from Google Search Console via this command:

php artisan keywords:check-search-volume https://tuikhoeconban.com --limit=1000

This will pull data from Google Search Console and check with our database. If we have that keyword in the database, then it will create or update the search volumes data in search_volumes table.

Notice: This PR requires changes from this PR (TIPOFF/laravel-google-api#36) to work.

This is the video I demonstrated how it works: https://www.youtube.com/watch?v=qglfB5efRHY

@phuclh
Copy link
Contributor Author

phuclh commented Apr 21, 2021

Fixes #83

@drewroberts
Copy link
Member

This is the video I demonstrated how it works: https://www.youtube.com/watch?v=qglfB5efRHY

THIS IS GREAT! Thank you for creating a video showing me the code in action, @phuclh!

@phuclh
Copy link
Contributor Author

phuclh commented Apr 22, 2021

@drewroberts I still have one more question. Do we save the search volume data every range (month) or we only save the lastest range (month)?

@drewroberts
Copy link
Member

For now, let's just save the latest range every month.

@drewroberts
Copy link
Member

@pdbreen Could you fix the psalm errors on this PR?

@pdbreen
Copy link

pdbreen commented Apr 23, 2021

@drewroberts psalm errors are fixed. Biggest issue was composer.json allowing php 7.3 but code was using php 7.4 syntax.

@drewroberts
Copy link
Member

Thank you, @pdbreen!

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @phuclh! 📻

@drewroberts drewroberts merged commit e983326 into main Apr 23, 2021
@drewroberts drewroberts deleted the omnia/feature/#126_add_google_search_console branch April 23, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants