Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factories #52

Merged
merged 8 commits into from
Mar 11, 2021
Merged

Conversation

wolfrednicolas
Copy link
Contributor

  • PlaceDetail
  • PlaceHour

@drewroberts drewroberts self-requested a review March 10, 2021 21:20
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🔌

@wolfrednicolas
Copy link
Contributor Author

@pdbreen I have a question, I've seen this kind of issue in several packages, after check, I'm not able to understand what's going on...
for example

this is the issue

Caused by
Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[HY000]: General error: 1 no such table: domestic_addresses

image

Also I'm using the newest versions of the packages

image

image

@pdbreen
Copy link

pdbreen commented Mar 10, 2021

Providers for package dependencies need to be added to the base TestCase getPackageProviders response. In this case, AddressesServiceProvider::class needed to be added.

https://github.com/tipoff/seo/blob/wolfrednicolas/feature/add-nova-resources/tests/TestCase.php

@wolfrednicolas
Copy link
Contributor Author

thank you that work @pdbreen

@wolfrednicolas
Copy link
Contributor Author

@drewroberts I think this is ready to merge, however; just one of the test is failing in the P7.4 - L8.* - prefer-lowest - ubuntu-lates

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚁

@drewroberts drewroberts merged commit bbc4a04 into main Mar 11, 2021
@drewroberts drewroberts deleted the wolfrednicolas/feature/add-nova-resources branch March 11, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants