-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add factories #52
Add factories #52
Conversation
wolfrednicolas
commented
Mar 10, 2021
- PlaceDetail
- PlaceHour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🔌
@pdbreen I have a question, I've seen this kind of issue in several packages, after check, I'm not able to understand what's going on... this is the issue Caused by Also I'm using the newest versions of the packages |
Providers for package dependencies need to be added to the base TestCase https://github.com/tipoff/seo/blob/wolfrednicolas/feature/add-nova-resources/tests/TestCase.php |
thank you that work @pdbreen |
@drewroberts I think this is ready to merge, however; just one of the test is failing in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚁