BusinessCategory #23 #64
Conversation
| @@ -12,7 +12,7 @@ public function up() | |||
| { | |||
| Schema::create('business_category_place', function (Blueprint $table) { | |||
| $table->id(); | |||
| $table->foreignIdFor(app('business_category')); | |||
There was a problem hiding this comment.
Let's add this class to the tipoff/support config. Can you do a PR for it?
| Schema::create('business_category_place', function (Blueprint $table) { | ||
| $table->id(); | ||
| $table->foreignIdFor(\Tipoff\Seo\Models\BusinessCategory::class); | ||
| $table->foreignIdFor(app('place')); | ||
| $table->timestamps(); | ||
|
|
||
| $table->unique(['business_category','place']); |
There was a problem hiding this comment.
See comment here:
There should be a polymorphic relationship between business_categories and place_details and gmb_details
There was a problem hiding this comment.
So this business_category_place table should not exist. A new table for the polymorphic relationships should be created. I'm not sure what to call it.
There was a problem hiding this comment.
what is the -able? detailable or categorizable?
There was a problem hiding this comment.
Hmm, let's use categorizable. I don't know what the name of that table should be. Maybe businesscategory_records like we did in the tipoff/statuses pacakge
There was a problem hiding this comment.
Why not just use the business_categories table and make it a morph for anything that needs a business category? Would just have name, categorizable_id, categorizable_type.
There was a problem hiding this comment.
Because I want that to be unique. I want to know what Business Categories are morphed to each. Not have 500 business categories for the same thing.
There was a problem hiding this comment.
If you have a location with a morphed business category, that will be unique to that model: categorizable_id=<location_id> categorizable_type='/tipoff/Locations/Models/Location', name=<gmb_category>
There was a problem hiding this comment.
Correct. I don't want it to be unique to the model. I want business_cateogries to be unique names and another model that will be unique to the model.
… for business category)
create BusinessCategory model, categories in migration; business_category_place join table migration; add relations to Place and BusinessCategory