Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fake data that adapt global scope active of Keyword #94

Conversation

phuclh
Copy link
Contributor

@phuclh phuclh commented Apr 13, 2021

Screen Shot 2021-04-12 at 11 54 18 PM

This global scope will filter out all keywords were created from KeywordFactory. This PR will create keywords that adapt to that global scope so the index_by_role test of Keyword will be run correctly.

@phuclh phuclh requested a review from drewroberts April 13, 2021 06:55
…dapt_global_scope_active_of_keyword' into omnia/feature/create_fake_data_adapt_global_scope_active_of_keyword
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU! 🇺🇸

@drewroberts drewroberts merged commit 08d1c5c into main Apr 13, 2021
@drewroberts drewroberts deleted the omnia/feature/create_fake_data_adapt_global_scope_active_of_keyword branch April 13, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants