Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected booking interfaces #107

Merged
merged 11 commits into from
Mar 17, 2021

Conversation

sl0wik
Copy link
Contributor

@sl0wik sl0wik commented Mar 17, 2021

No description provided.

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🍪

@sl0wik sl0wik changed the title Corrected booking interfaces WIP: Corrected booking interfaces Mar 17, 2021
@drewroberts
Copy link
Member

Shouldn't this be Experience instead of Subject?

What is being booked is an escape room experience of a time Slot in the Room, not the room itself. We could use both Subject & Experience, but I don't think the Bookings package really needs to know about the Subject of the Experience.

@sl0wik sl0wik changed the title WIP: Corrected booking interfaces Corrected booking interfaces Mar 17, 2021
@sl0wik sl0wik changed the title Corrected booking interfaces WIP: Corrected booking interfaces Mar 17, 2021
@sl0wik sl0wik changed the title WIP: Corrected booking interfaces Corrected booking interfaces Mar 17, 2021
@drewroberts drewroberts merged commit ba8a653 into main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants